Opened 7 years ago

Closed 7 years ago

#16596 closed enhancement (fixed)

Add tests for the category of domains

Reported by: tscrim Owned by: tscrim
Priority: minor Milestone: sage-6.3
Component: categories Keywords:
Cc: saraedum Merged in:
Authors: Travis Scrimshaw Reviewers: Julian Rueth
Report Upstream: N/A Work issues:
Branch: 611f2ff (Commits, GitHub, GitLab) Commit: 611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
Dependencies: #15191 Stopgaps:

Status badges

Description

Checking for zero divisors.

Change History (6)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/categories/domains_test-16596
  • Commit set to 8436633ed36e9036e54339773b768c7a185b1f7f
  • Status changed from new to needs_review

Last 10 new commits:

​6bdf328Add quotient with remainder and euclidean degree tests to the category of euclidean domains
​654b8a8Implement a non-trivial some_elements() for polynomial rings
​9c44becMerge branch 'develop' into ticket/15191-EuclideanDomains_tests
​4aa4264Merge branch 'develop' into ticket/15191
​d48d16aFixed doctests for euclidean_degree
​18722dfeuclidean_degree() is not defined for zero element
​f60c865Fixed documentation doctests
​ce64f71Some minor review tweaks.
​75fa2dbMade a note about zero divisors.
​8436633Added test for zero divisors for domains.

comment:2 Changed 7 years ago by tscrim

  • Dependencies set to #15191

comment:3 follow-up: Changed 7 years ago by saraedum

  • Reviewers set to Julian Rueth

I removed the except AttributeError on is_exact(), since all rings in Sage implement is_exact().

You can change this to positive review if you are happy with my changes.

comment:4 Changed 7 years ago by saraedum

  • Branch changed from public/categories/domains_test-16596 to u/saraedum/ticket/16596
  • Created changed from 07/01/14 03:22:23 to 07/01/14 03:22:23
  • Modified changed from 08/04/14 08:10:59 to 08/04/14 08:10:59

comment:5 in reply to: ↑ 3 Changed 7 years ago by tscrim

  • Commit changed from 8436633ed36e9036e54339773b768c7a185b1f7f to 611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
  • Status changed from needs_review to positive_review

Replying to saraedum:

I removed the except AttributeError on is_exact(), since all rings in Sage implement is_exact().

Since Parent implements is_exact, we're okay.

You can change this to positive review if you are happy with my changes.

Done. Thanks for doing the review.

EDIT - IDK why the commit didn't change with your update, but 611f2ff... is the correct commit according to the branch. The created/modified being changed is also strange; perhaps a bug in trac *shrugs*.

New commits:

​116bbfaMerge branch 'develop' into ticket/16596
​611f2ffAdded a note to _test_zero_divisors() for domains
Last edited 7 years ago by tscrim (previous) (diff)

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/saraedum/ticket/16596 to 611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.