Opened 8 years ago
Closed 8 years ago
#16589 closed defect (fixed)
FSMState.__copy__: copy color
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.3 |
Component: | finite state machines | Keywords: | finite_state_machine |
Cc: | skropf, dkrenn | Merged in: | |
Authors: | Clemens Heuberger | Reviewers: | Daniel Krenn |
Report Upstream: | N/A | Work issues: | |
Branch: | 53b732e (Commits, GitHub, GitLab) | Commit: | 53b732eed50119d729f071252ee74185b47f44af |
Dependencies: | #16191 | Stopgaps: |
Description (last modified by )
In contrast to FSMState.__deepcopy__
, FSMState.__copy__
omitted copying the attribute color
. This is now fixed.
Change History (5)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Commit changed from 81d8722eb2579cbcb09ab0ef28436988801950fa to 53b732eed50119d729f071252ee74185b47f44af
comment:3 Changed 8 years ago by
- Dependencies set to #16191
- Description modified (diff)
- Summary changed from FSMState.__copy__: copy final_word_out and color to FSMState.__copy__: copy color
Last 10 new commits:
bcf3308 | Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.
|
8d29348 | Correct TeX errors (raw string vs. string) in docstring (Gray Code)
|
ae8ec6b | Modified a few docstrings to reflect use of final output word
|
4927542 | removed determine_alphabets=True from docstrings because it is the default anyway
|
ba07d56 | Use iterators instead of lists
|
0be171e | Added examples for FiniteStateMachine.equivalence_classes
|
95414f5 | NotImplementedError in _composition_explorative_ if there are final word outs
|
c3f2b33 | corrected spacing
|
d1f3e21 | trac #16191: Reviewer Patch: Move one example; spacing; typo; punctuation
|
53b732e | Merge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out
|
comment:4 Changed 8 years ago by
- Reviewers set to Daniel Krenn
- Status changed from needs_review to positive_review
Patch is fine; tests passed.
comment:5 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/copy-state-color-final-word-out to 53b732eed50119d729f071252ee74185b47f44af
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.
Correct TeX errors (raw string vs. string) in docstring (Gray Code)
Modified a few docstrings to reflect use of final output word
removed determine_alphabets=True from docstrings because it is the default anyway
Use iterators instead of lists
Added examples for FiniteStateMachine.equivalence_classes
NotImplementedError in _composition_explorative_ if there are final word outs
corrected spacing
trac #16191: Reviewer Patch: Move one example; spacing; typo; punctuation
Merge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out