Opened 8 years ago
Closed 8 years ago
#16589 closed defect (fixed)
FSMState.__copy__: copy color
| Reported by: | Clemens Heuberger | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.3 |
| Component: | finite state machines | Keywords: | finite_state_machine |
| Cc: | Sara Kropf, Daniel Krenn | Merged in: | |
| Authors: | Clemens Heuberger | Reviewers: | Daniel Krenn |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 53b732e (Commits, GitHub, GitLab) | Commit: | 53b732eed50119d729f071252ee74185b47f44af |
| Dependencies: | #16191 | Stopgaps: |
Status badges
Description (last modified by )
In contrast to FSMState.__deepcopy__, FSMState.__copy__ omitted copying the attribute color. This is now fixed.
Change History (5)
comment:1 Changed 8 years ago by
| Status: | new → needs_review |
|---|
comment:2 Changed 8 years ago by
| Commit: | 81d8722eb2579cbcb09ab0ef28436988801950fa → 53b732eed50119d729f071252ee74185b47f44af |
|---|
comment:3 Changed 8 years ago by
| Dependencies: | → #16191 |
|---|---|
| Description: | modified (diff) |
| Summary: | FSMState.__copy__: copy final_word_out and color → FSMState.__copy__: copy color |
Last 10 new commits:
| bcf3308 | Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.
|
| 8d29348 | Correct TeX errors (raw string vs. string) in docstring (Gray Code)
|
| ae8ec6b | Modified a few docstrings to reflect use of final output word
|
| 4927542 | removed determine_alphabets=True from docstrings because it is the default anyway
|
| ba07d56 | Use iterators instead of lists
|
| 0be171e | Added examples for FiniteStateMachine.equivalence_classes
|
| 95414f5 | NotImplementedError in _composition_explorative_ if there are final word outs
|
| c3f2b33 | corrected spacing
|
| d1f3e21 | trac #16191: Reviewer Patch: Move one example; spacing; typo; punctuation
|
| 53b732e | Merge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out
|
comment:4 Changed 8 years ago by
| Reviewers: | → Daniel Krenn |
|---|---|
| Status: | needs_review → positive_review |
Patch is fine; tests passed.
comment:5 Changed 8 years ago by
| Branch: | u/cheuberg/fsm/copy-state-color-final-word-out → 53b732eed50119d729f071252ee74185b47f44af |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.Correct TeX errors (raw string vs. string) in docstring (Gray Code)Modified a few docstrings to reflect use of final output wordremoved determine_alphabets=True from docstrings because it is the default anywayUse iterators instead of listsAdded examples for FiniteStateMachine.equivalence_classesNotImplementedError in _composition_explorative_ if there are final word outscorrected spacingtrac #16191: Reviewer Patch: Move one example; spacing; typo; punctuationMerge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out