Opened 5 years ago

Closed 5 years ago

#16582 closed enhancement (fixed)

MOLS: Table with n<600 and updated syntax

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 01689fd (Commits) Commit: 01689fdd0163748dcb407f3c36e8c36f78e83fba
Dependencies: #16535 Stopgaps:

Description

Heeeeere it is ! A longer table, as we can compute it rather quickly now, aaaaand also a change in the syntax of the new function mutually_orthogonal_latin_squares which accepted n,k when all others (TD and OA) expected k,n.

Nathann

Change History (20)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16582
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to ae762e6f9dbbc90061378913b9fcd8d33d974fd2

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

8da2c73trac #16503: Broken doc
0d768dftrac #16535: merge #16503
002ceeetrac #16524: OA(9,135)
c6e78c8trac #16524: move the cyclic difference set to the constructor
a0294d3trac #16524: more comments in the doc
41b7f00trac #16535: merge #16524
3487f09trac #16528: OA(9,120)
c80b7f4trac #16528: review
2b3c809trac #16535: merge #16528
ae762e6trac #16582: MOLS: Table with n<600 and updated syntax

comment:3 follow-up: Changed 5 years ago by vdelecroix

Hi Nathann,

How does it fit with #16541?

Vincent

comment:4 Changed 5 years ago by ncohen

Arggggggg... Yes, it is in conflict T_T

Nathann

comment:5 Changed 5 years ago by ncohen

  • Dependencies changed from #16535 to #16541
  • Status changed from needs_review to needs_work

comment:6 Changed 5 years ago by ncohen

  • Dependencies changed from #16541 to #16541, #16535
  • Status changed from needs_work to needs_review

Funny. There was no conflict during the merge. Git is smarter than I thought ;-)

Nathann

comment:7 Changed 5 years ago by git

  • Commit changed from ae762e6f9dbbc90061378913b9fcd8d33d974fd2 to 4e8556de487dd213b4b5385b1a42f2aec1241792

Branch pushed to git repo; I updated commit sha1. New commits:

29c48c3trac #16541: MOLS table : 10 000 integers
4e8556dtrac #16582: Merged with #16541

comment:8 Changed 5 years ago by vdelecroix

But I am less smart than git and it will help me for the reviews ;-) Thanks.

comment:9 Changed 5 years ago by git

  • Commit changed from 4e8556de487dd213b4b5385b1a42f2aec1241792 to ae762e6f9dbbc90061378913b9fcd8d33d974fd2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:10 Changed 5 years ago by ncohen

  • Dependencies changed from #16541, #16535 to #16535

comment:11 in reply to: ↑ 3 Changed 5 years ago by ncohen

How does it fit with #16541?

Let me answer your question again : there is no conflict between the two, they don't touch the same parts of the code :-P

Nathann

comment:12 Changed 5 years ago by git

  • Commit changed from ae762e6f9dbbc90061378913b9fcd8d33d974fd2 to 442b328872143a1703d1feb6069447ae7b178ce1

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

442b328trac #16582: MOLS: Table with n<600 and updated syntax

comment:13 follow-up: Changed 5 years ago by vdelecroix

Hi Nathann,

  • You could remove the # long time for the test at lines 480 and 488.
  • We will run into troubles if somebody asks for a table larger than the one available (with compare=True). There is no overflow check. Actually, it is not that bad, on the line failure you will get a IndexError.

Otherwise, looks good to me. What do you think of having designs.MOLS_table globally available? It is a cool feature.

Vincent

comment:14 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_info

comment:15 in reply to: ↑ 13 Changed 5 years ago by ncohen

  • Status changed from needs_info to needs_review
  • You could remove the # long time for the test at lines 480 and 488.

Done.

  • We will run into troubles if somebody asks for a table larger than the one available (with compare=True).

You mean 10 000 ? O_o

Otherwise, looks good to me. What do you think of having designs.MOLS_table globally available? It is a cool feature.

Well, it is a cool feature but designs.<tab> is meant to gather constructors, so where could we put it ?...

Plus it is "cool" but it is mostly a toy. And it is well advertised at the head of the MOLS module's doc.

Nathann

comment:16 Changed 5 years ago by git

  • Commit changed from 442b328872143a1703d1feb6069447ae7b178ce1 to e16a2e28863ef5c6c323570bdeddff47643d13ef

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e16a2e2trac #16582: MOLS: Table with n<600 and updated syntax

comment:17 Changed 5 years ago by git

  • Commit changed from e16a2e28863ef5c6c323570bdeddff47643d13ef to 01689fdd0163748dcb407f3c36e8c36f78e83fba

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

01689fdtrac #16582: MOLS: Table with n<600 and updated syntax

comment:18 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to positive_review

Good to go!

Vincent

comment:19 Changed 5 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

comment:20 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16582 to 01689fdd0163748dcb407f3c36e8c36f78e83fba
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.