Opened 7 years ago
Closed 6 years ago
#16574 closed enhancement (duplicate)
Gaussian sampling from ZZ[x]/<f>
Reported by: | malb | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | PLEASE CHANGE | Keywords: | sd59 |
Cc: | Merged in: | ||
Authors: | Reviewers: | Martin Albrecht | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/malb/polynomial_quotient_integer_dense_flint (Commits, GitHub, GitLab) | Commit: | cf0edb89c128854bc7ca7e2718d7d770e96ce0cd |
Dependencies: | #15915 | Stopgaps: |
Description (last modified by )
sage: P.<x> = PolynomialRing(ZZ) sage; R.<x> = P.quotient(P.cyclotomic_polynomial(128)) sage: f = R.random_element(sigma=128, distribution='gaussian')
Change History (15)
comment:1 Changed 7 years ago by
- Dependencies set to #15915
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Status changed from needs_review to needs_work
comment:4 Changed 7 years ago by
- Commit changed from 833723c6f826d2935c27d3b5d57261a79aaaab59 to cf0edb89c128854bc7ca7e2718d7d770e96ce0cd
comment:5 Changed 7 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
- Summary changed from ZZ[x]/<f> to Gaussian sampling from ZZ[x]/<f>
comment:6 Changed 7 years ago by
This ticket also cleans up a bit of FLINT stuff due to its history.
comment:7 Changed 7 years ago by
- Status changed from needs_review to needs_info
Some patchbot plugins failed. Are these legitimate errors? Or are my patchbot broken (again)?
comment:8 follow-up: ↓ 10 Changed 7 years ago by
sage.rings.polynomial.polynomial_quotient_ring.PolynomialQuotientRing_integer.random_element:14: WARNING: Inline literal start-string without end-string.
looks like my fault, but
File "src/sage/interfaces/expect.py", line 790, in sage.interfaces.expect.Expect._eval_line Failed example: singular.interrupt(timeout=3) # sometimes very slow (up to 60s on sage.math, 2012) Expected: False Got: True
looks unrelated.
comment:9 follow-up: ↓ 11 Changed 7 years ago by
I just rebuilt the docs and didn't get an error, maybe patchbot used an older check in?
comment:10 in reply to: ↑ 8 Changed 7 years ago by
Replying to malb:
File "src/sage/interfaces/expect.py", line 790, in sage.interfaces.expect.Expect._eval_line Failed example: singular.interrupt(timeout=3) # sometimes very slow (up to 60s on sage.math, 2012) Expected: False Got: True
This is some typical noise my patchbot creates. No clue why.
comment:11 in reply to: ↑ 9 Changed 7 years ago by
Replying to malb:
I just rebuilt the docs and didn't get an error, maybe patchbot used an older check in?
Ok. I'll have it retry. You can see which commit it used on the patchbot page; in this case it used cf0edb89c128854bc7ca7e2718d7d770e96ce0cd which seems to be the right one.
comment:12 Changed 7 years ago by
- Status changed from needs_info to needs_review
comment:13 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-duplicate/invalid/wontfix
comment:14 Changed 6 years ago by
- Reviewers set to Martin Albrecht
- Status changed from needs_review to positive_review
comment:15 Changed 6 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
implemented lift()
fixed doctest failures
fixed PARI conversion
turns out this special implementation offers little benefit, reverting