Opened 6 years ago

Last modified 6 years ago

#16573 new enhancement

Animations saved without visible effect

Reported by: gagern Owned by:
Priority: trivial Milestone: sage-6.4
Component: graphics Keywords:
Cc: Merged in:
Authors: Martin von Gagern Reviewers:
Report Upstream: N/A Work issues:
Branch: u/gagern/ticket/16573 (Commits) Commit: da6a71c218e03a2c8c50cbd55de7edc0f2fdcf8e
Dependencies: #16571 Stopgaps:

Description

At the moment, the methods Animation.gif and Animation.ffmpeg will, when called without arguments, create a new temporary file in some temporary directory without telling anyone about it. Apparently, in previous versions the file was created in the current working directory, where the notebook would pick them up. But this is no longer the case. One can pass an argument called show_path to learn about the chosen path, or an argument called savefile to specify the name explicitely. But the version without arguments seems rather confusing to me.

Therefore I suggest to change the code, and have it return the name of the generated file. The Animation.png method already returns the path of the directory it created, so in a sense this would be consistent. Notebook users would see some feedback indicating what actually happened. In order to see the file content instead of its path, calling Animation.show() seems more appropriate. The documentation would have to be adjusted as well, since they claim that the generated file would be shown in notebook, which isn't the case.

Change History (4)

comment:1 Changed 6 years ago by gagern

  • Branch set to u/gagern/ticket/16573
  • Created changed from 06/27/14 20:19:43 to 06/27/14 20:19:43
  • Modified changed from 06/27/14 20:19:43 to 06/27/14 20:19:43

comment:2 Changed 6 years ago by gagern

  • Authors set to Martin von Gagern
  • Commit set to da6a71c218e03a2c8c50cbd55de7edc0f2fdcf8e
  • Dependencies set to #16571

I addressed this as part of my work for #16533. Later I split that ticket. So the changes I have now are based upon modifications from #16571. I don't expect anyone to review all these modifications before the dependency has been reviewed. Therefore I won't request a review just now. I'm mostly filing this ticket so my branch won't be forgotten. In the event that my underlying changes get rejected, one might address this issue here independently. The main reason I didn't do that is because I rely on 005b83f to move the savefile manipulation to a point before the case distinction.


New commits:

ac83bdbProper hyperlink formatting in animate documentation.
031b97eBase Animation.show on Animation.save, and pass more arguments.
005b83fUnify file name generation for animations.
da6a71cMake animation exporters return absolute file names.

comment:3 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:4 Changed 6 years ago by gagern

Since #16645 the methods will store their files in a location where the notebook will pick them up. So in the embedded case, there is a visible effect. I wonder whether we should cater for the non-notebook case as well. I'm not convinced myself.

Note: See TracTickets for help on using tickets.