Opened 7 years ago

Closed 7 years ago

#16568 closed task (fixed)

remove desolve_system_strings()

Reported by: rws Owned by:
Priority: minor Milestone: sage-6.4
Component: calculus Keywords: deprecation, removal, beginner
Cc: Merged in:
Authors: Sergey Bykov Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: 7ef2572 (Commits, GitHub, GitLab) Commit: 7ef2572d4c80968c6b44cc926ff4e48491fd35c1
Dependencies: Stopgaps:

Status badges

Description

kcrisman in comment 54 of #8734:

... see #8132 where it was first said to be obsolete, and it hasn't been in the global namespace since before 2010. That is pretty much equivalent to a deprecation to me. However, we should keep any non-overlapping examples ...

Change History (14)

comment:1 Changed 7 years ago by kcrisman

  • Keywords beginner added
  • Priority changed from major to minor

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:3 Changed 7 years ago by captaintrunky

  • Branch set to u/captaintrunky/remove_desolve_system_strings__

comment:4 Changed 7 years ago by captaintrunky

  • Authors set to Sergey Bykov
  • Commit set to b9e84768a23321550136de609e8d88cb06aca79d
  • Status changed from new to needs_review

New commits:

b9e8476Obsolete function desolve_system_string is removed

comment:5 follow-up: Changed 7 years ago by kcrisman

Hi! Thanks for joining Sage development. Just curious - do you think that any of the examples in this function are worth rescuing for doctesting purposes (I mean if they were changed to the standard desolve syntax)? It's always worth checking for this.

comment:6 in reply to: ↑ 5 Changed 7 years ago by captaintrunky

Replying to kcrisman:

Hi! Thanks for joining Sage development. Just curious - do you think that any of the examples in this function are worth rescuing for doctesting purposes (I mean if they were changed to the standard desolve syntax)? It's always worth checking for this.

Hi, thanks. I'm going to agree with you on this. It is not so time consuming to modify and add these little tests, while an additional feedback is often useful.

comment:7 Changed 7 years ago by git

  • Commit changed from b9e84768a23321550136de609e8d88cb06aca79d to 210b69f474129b1c7b3b29c1547f046da0aa96ba

Branch pushed to git repo; I updated commit sha1. New commits:

210b69fAdditional test for 'desolve()' method have been recovered from obsolete 'desolve_system_string()' routine

comment:8 Changed 7 years ago by kcrisman

  • Status changed from needs_review to needs_work

Nice! But you need to do a bit more indentation for the last block, and should probably do :trac:`16568` for the Trac reference.

comment:9 Changed 7 years ago by git

  • Commit changed from 210b69f474129b1c7b3b29c1547f046da0aa96ba to 32cbad4d5f08dccc45f1bc0c3cfdbdf455cb5973

Branch pushed to git repo; I updated commit sha1. New commits:

32cbad4Formatting fixes

comment:10 Changed 7 years ago by captaintrunky

  • Status changed from needs_work to needs_review

comment:11 Changed 7 years ago by kcrisman

Dedent

Now type show(P1), show(P2) to view these plots.

so it is at the same indentation level as other text for the documentation to look right. But otherwise this is great.

comment:12 Changed 7 years ago by git

  • Commit changed from 32cbad4d5f08dccc45f1bc0c3cfdbdf455cb5973 to 7ef2572d4c80968c6b44cc926ff4e48491fd35c1

Branch pushed to git repo; I updated commit sha1. New commits:

7ef2572Formatting fixes

comment:13 Changed 7 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

comment:14 Changed 7 years ago by vbraun

  • Branch changed from u/captaintrunky/remove_desolve_system_strings__ to 7ef2572d4c80968c6b44cc926ff4e48491fd35c1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.