Opened 7 years ago
Closed 7 years ago
#16568 closed task (fixed)
remove desolve_system_strings()
Reported by:  rws  Owned by:  

Priority:  minor  Milestone:  sage6.4 
Component:  calculus  Keywords:  deprecation, removal, beginner 
Cc:  Merged in:  
Authors:  Sergey Bykov  Reviewers:  KarlDieter Crisman 
Report Upstream:  N/A  Work issues:  
Branch:  7ef2572 (Commits, GitHub, GitLab)  Commit:  7ef2572d4c80968c6b44cc926ff4e48491fd35c1 
Dependencies:  Stopgaps: 
Change History (14)
comment:1 Changed 7 years ago by
 Keywords beginner added
 Priority changed from major to minor
comment:2 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:3 Changed 7 years ago by
 Branch set to u/captaintrunky/remove_desolve_system_strings__
comment:4 Changed 7 years ago by
 Commit set to b9e84768a23321550136de609e8d88cb06aca79d
 Status changed from new to needs_review
comment:5 followup: ↓ 6 Changed 7 years ago by
Hi! Thanks for joining Sage development. Just curious  do you think that any of the examples in this function are worth rescuing for doctesting purposes (I mean if they were changed to the standard desolve
syntax)? It's always worth checking for this.
comment:6 in reply to: ↑ 5 Changed 7 years ago by
Replying to kcrisman:
Hi! Thanks for joining Sage development. Just curious  do you think that any of the examples in this function are worth rescuing for doctesting purposes (I mean if they were changed to the standard
desolve
syntax)? It's always worth checking for this.
Hi, thanks. I'm going to agree with you on this. It is not so time consuming to modify and add these little tests, while an additional feedback is often useful.
comment:7 Changed 7 years ago by
 Commit changed from b9e84768a23321550136de609e8d88cb06aca79d to 210b69f474129b1c7b3b29c1547f046da0aa96ba
Branch pushed to git repo; I updated commit sha1. New commits:
210b69f  Additional test for 'desolve()' method have been recovered from obsolete 'desolve_system_string()' routine

comment:8 Changed 7 years ago by
 Status changed from needs_review to needs_work
Nice! But you need to do a bit more indentation for the last block, and should probably do :trac:`16568`
for the Trac reference.
comment:9 Changed 7 years ago by
 Commit changed from 210b69f474129b1c7b3b29c1547f046da0aa96ba to 32cbad4d5f08dccc45f1bc0c3cfdbdf455cb5973
Branch pushed to git repo; I updated commit sha1. New commits:
32cbad4  Formatting fixes

comment:10 Changed 7 years ago by
 Status changed from needs_work to needs_review
comment:11 Changed 7 years ago by
Dedent
Now type show(P1), show(P2) to view these plots.
so it is at the same indentation level as other text for the documentation to look right. But otherwise this is great.
comment:12 Changed 7 years ago by
 Commit changed from 32cbad4d5f08dccc45f1bc0c3cfdbdf455cb5973 to 7ef2572d4c80968c6b44cc926ff4e48491fd35c1
Branch pushed to git repo; I updated commit sha1. New commits:
7ef2572  Formatting fixes

comment:13 Changed 7 years ago by
 Reviewers set to KarlDieter Crisman
 Status changed from needs_review to positive_review
comment:14 Changed 7 years ago by
 Branch changed from u/captaintrunky/remove_desolve_system_strings__ to 7ef2572d4c80968c6b44cc926ff4e48491fd35c1
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Obsolete function desolve_system_string is removed