Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#16563 closed enhancement (fixed)

simple model for function fields

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-8.0
Component: commutative algebra Keywords: sd59, sd86.5
Cc: jpflori Merged in:
Authors: Julian Rüth Reviewers: Hanson Smith
Report Upstream: N/A Work issues:
Branch: eebe2c8 (Commits, GitHub, GitLab) Commit:
Dependencies: #16523, #16566, #16521 Stopgaps:

Status badges

Description (last modified by saraedum)

This ticket implements simple models of function fields, i.e., given a tower of function fields, it constructs an isomorphic function field which is a simple extension of a rational function field.

Change History (33)

comment:1 Changed 7 years ago by saraedum

  • Authors set to Julian Rueth
  • Description modified (diff)
  • Summary changed from simple_model() for function fields to simple model for function fields

comment:2 Changed 7 years ago by saraedum

  • Keywords sd59 added

comment:3 Changed 7 years ago by saraedum

  • Dependencies set to #16523

comment:4 Changed 7 years ago by saraedum

  • Dependencies changed from #16523 to #16523, #16566

comment:5 Changed 7 years ago by saraedum

  • Dependencies changed from #16523, #16566 to #16523, #16566, #16521

comment:6 Changed 7 years ago by saraedum

  • Branch set to u/saraedum/ticket/16563
  • Created changed from 06/27/14 04:43:51 to 06/27/14 04:43:51
  • Modified changed from 06/27/14 08:54:14 to 06/27/14 08:54:14

comment:7 Changed 7 years ago by saraedum

  • Status changed from new to needs_review

comment:8 Changed 7 years ago by git

  • Commit set to a54e0dd95e6a20144e79df2273ee32eac8133e08

Branch pushed to git repo; I updated commit sha1. New commits:

5c3e74bMerge branch 'develop' into ticket/16523
a54e0ddMerge branch 'ticket/16523' into ticket/16563

comment:9 Changed 7 years ago by git

  • Commit changed from a54e0dd95e6a20144e79df2273ee32eac8133e08 to 0a63b2e2592ef85744e4e2067cfd2047f3a41c5c

Branch pushed to git repo; I updated commit sha1. New commits:

0a63b2eminor docstring fix

comment:10 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:11 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

some failing doctests, see patchbot report

comment:12 Changed 5 years ago by git

  • Commit changed from 0a63b2e2592ef85744e4e2067cfd2047f3a41c5c to 5509ad6e7a2843afef147b3ab574a1589e4a3477

Branch pushed to git repo; I updated commit sha1. New commits:

5509ad6Merge branch 'develop' of git://trac.sagemath.org/sage into t/16563/ticket/16563

comment:13 Changed 5 years ago by saraedum

  • Authors changed from Julian Rueth to Julian Rüth
  • Status changed from needs_work to needs_review

comment:14 Changed 5 years ago by git

  • Commit changed from 5509ad6e7a2843afef147b3ab574a1589e4a3477 to c2f9d4a0387318f037da3fb8834dc8ed8bacc3ef

Branch pushed to git repo; I updated commit sha1. New commits:

7adce38Fix doctests in function fields
c2f9d4aMake function field factorization more robust

comment:15 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

does not apply

comment:16 Changed 5 years ago by git

  • Commit changed from c2f9d4a0387318f037da3fb8834dc8ed8bacc3ef to f1c1eaaa0157563d97896924c631b7bb16c0100b

Branch pushed to git repo; I updated commit sha1. New commits:

f1c1eaaMerge branch 'develop' into t/16563/ticket/16563

comment:17 Changed 5 years ago by git

  • Commit changed from f1c1eaaa0157563d97896924c631b7bb16c0100b to ce3d0efb498625d5f7fa485146fc6278c00d6f21

Branch pushed to git repo; I updated commit sha1. New commits:

ce3d0efMerge branch 'develop' into t/16563/ticket/16563

comment:18 Changed 5 years ago by saraedum

  • Status changed from needs_work to needs_review

Doctests in function_fields/ pass again. Let's see what the patchbots think.

comment:19 Changed 5 years ago by jpflori

  • Cc jpflori added

comment:20 Changed 5 years ago by chapoton

@saraedum, could you please take care of your patchbot multscher, that misbehaves currently ?

I found not other way to contact you.

comment:21 Changed 5 years ago by saraedum

Sure. I stopped it.

comment:22 Changed 4 years ago by chapoton

  • Branch changed from u/saraedum/ticket/16563 to public/16563
  • Commit changed from ce3d0efb498625d5f7fa485146fc6278c00d6f21 to aa5b8876304c6b9510173d6206a467162734334b

New commits:

aa5b887Merge branch 'u/saraedum/ticket/16563' in 8.0.b8

comment:23 Changed 4 years ago by hwsmith

I was able to successfully compile this ticket. This ticket also passed the doctests. I am definitely a newbie, so I wasn't able to confidently check everything on the reviewer checklist, but this ticket satisfied what I could check.

comment:24 Changed 4 years ago by saraedum

Thanks for having a look :) That sounds good enough for me.

hwsmith: What is missing for you from the checklist? You can put your name into the "Reviewers" field in any case?

Last edited 4 years ago by saraedum (previous) (diff)

comment:25 Changed 4 years ago by hwsmith

  • Reviewers set to hwsmith

comment:26 Changed 4 years ago by hwsmith

  • Reviewers changed from hwsmith to Hanson Smith

comment:27 Changed 4 years ago by saraedum

  • Keywords sd86.5 added

comment:28 Changed 4 years ago by hwsmith

  • Status changed from needs_review to positive_review

comment:29 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:30 Changed 4 years ago by git

  • Commit changed from aa5b8876304c6b9510173d6206a467162734334b to eebe2c8c1ef5f3d90358d975449c8db77572f2b1

Branch pushed to git repo; I updated commit sha1. New commits:

eebe2c8Merge branch 'develop' into t/16563/public/16563

comment:31 Changed 4 years ago by saraedum

  • Status changed from needs_work to positive_review

resolved conflicts. tests pass.

comment:32 Changed 4 years ago by vbraun

  • Branch changed from public/16563 to eebe2c8c1ef5f3d90358d975449c8db77572f2b1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:33 Changed 4 years ago by roed

  • Commit eebe2c8c1ef5f3d90358d975449c8db77572f2b1 deleted
  • Milestone changed from sage-6.4 to sage-8.0
Note: See TracTickets for help on using tickets.