Opened 5 years ago
Closed 5 years ago
#16558 closed enhancement (fixed)
Add note about github integration to developer guide.
| Reported by: | github/robertwb | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.3 |
| Component: | documentation | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Robert Bradshaw | Reviewers: | Volker Braun |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 116a6ee (Commits) | Commit: | 116a6ee4ddfa68f9a42035615dcac1ad1b424bb3 |
| Dependencies: | Stopgaps: |
Description
Pull requests, including subsequent comments, are pushed to trac.
Change History (6)
comment:1 Changed 5 years ago by
- Branch set to u/github/ticket/16558
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit set to 116a6ee4ddfa68f9a42035615dcac1ad1b424bb3
- Component changed from PLEASE CHANGE to documentation
- Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 5 years ago by
Can you explain somewhere how this works and what needs to be running? Is it some server you setup somewhere?
comment:4 Changed 5 years ago by
There's a 100-line server at http://trac.sagemath.org:12000/ (source /home/robertwb/github-trac/listen.py) that listens for github web hooks https://developer.github.com/webhooks/. I'm just running it manually now, long term we'll probably want to incorporate it into apache (via mod_wsgi). Right now it has the github user password in the source, and uses my ssh keys (on trac.sagemath.org) to push to trac, so we'll need to straighten that out before pushing the code somewhere more public.
comment:5 Changed 5 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
I'm using the github web hooks for the buildbot and they usually work but don't seem to be 100% reliable. Though might be something wrong on our side, too. Just FYI
comment:6 Changed 5 years ago by
- Branch changed from u/github/ticket/16558 to 116a6ee4ddfa68f9a42035615dcac1ad1b424bb3
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Add note about github integration to developer guide.