Opened 8 years ago

Closed 8 years ago

#16555 closed defect (fixed)

FiniteStateMachine.composition: Only deterministic machines for explorative algorithm

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.3
Component: finite state machines Keywords: finite_state_machine
Cc: skropf, dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: d218ba0 (Commits, GitHub, GitLab) Commit: d218ba0fdaf2fac6a79324cdaad296fefb3cba1f
Dependencies: #16191, #16539 Stopgaps:

Status badges

Description

The explorative algorithm for composition of finite state machines only handles deterministic machines. We now raise a NotImplementedError instead of simply taking a more or less random transition. This is a similar stop-gap measure as #16539. Once #16538 is implemented, non-deterministic machines shall also be implemented in the explorative composition, cf. #16548.

Change History (4)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Patch is fine.

comment:3 Changed 8 years ago by cheuberg

Trac's automerge fails; however, a manual merge into 6.3.beta5 succeeds.

comment:4 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/composition-explorative-force-deterministic to d218ba0fdaf2fac6a79324cdaad296fefb3cba1f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.