MOLS table : 10 000 integers

[ncohen]

Here it is !

Nathann

New SPKG : ​http://www.steinertriples.fr/ncohen/tmp/combinatorial_designs-20140630.tar.bz2

[git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​81b9448	trac #16430: put back the seealso
​0fa89d5	trac #16347: Wilson's construction with two truncated groups
​828ff22	trac #16437: cut the branches in W. dec. with two trunc. blocks
​8ebd21b	trac #16347: use is_sum_of_squares_pyx instead of two_squares
​0175134	trac #16347: doc + simplifications
​9ff5062	trac #16423: Table of MOLS from the handbook and comparison with Sage
​e64be98	trac #16423: tiny code improvement and alignment
​e948cf6	trac #16423: Aligning the alignment
​0a7d853	trac #16423: Broken doctests
​3bdf9d8	trac #16541: MOLS table : 10 000 integers

[vdelecroix]

Cool!

• Would be better if you read the handbook_data.txt only if compare=True.
• Would be nice if we could print the table of the handbook itself! Like a sage/compare/handbook alternative

Vincent

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​29c48c3

trac #16541: MOLS table : 10 000 integers

[ncohen]

I added a "if" to avoid loading the file when it is not necessary. If you want to be able to print the handbook's table you will have to add a commit.

Nathann

[vdelecroix]

Good to go! (doc builds and doctests pass)

Vincent

[ncohen]

Thanks !

Nathann

[vbraun]

reviewer name

[vbraun]

Missing file?

sage -t --long src/sage/combinat/designs/latin_squares.py
**********************************************************************
File "src/sage/combinat/designs/latin_squares.py", line 46, in sage.combinat.designs.latin_squares
Failed example:
    MOLS_table(15,compare=True) # long time
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.combinat.designs.latin_squares[2]>", line 1, in <module>
        MOLS_table(Integer(15),compare=True) # long time
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/designs/latin_squares.py", line 470, in MOLS_table
        handbook_file = open("handbook_data.txt",'r')
    IOError: [Errno 2] No such file or directory: 'handbook_data.txt'
**********************************************************************
File "src/sage/combinat/designs/latin_squares.py", line 460, in sage.combinat.designs.latin_squares.MOLS_table
Failed example:
    MOLS_table(5,compare=True) # long time
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.combinat.designs.latin_squares.MOLS_table[2]>", line 1, in <module>
        MOLS_table(Integer(5),compare=True) # long time
      File "/Users/buildbot/build/sage/bsd-1/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/designs/latin_squares.py", line 470, in MOLS_table
        handbook_file = open("handbook_data.txt",'r')
    IOError: [Errno 2] No such file or directory: 'handbook_data.txt'
**********************************************************************

[vdelecroix]

nope, it is in the commit ​29c48c3... I don't understand the error!!

EDIT: and the doctest pass on my computer!

REDIT: actually depending from where you run the computation the test fails or not

from SAGE_ROOT running

sage -t src/sage/combinat/designs/latin_squares.py

does fail!!

Vincent

[vdelecroix]

Easy solution:

move the file handbook_data.txt into local/share (where most of the raw data belong) and then use

import os.path
from sage.misc.misc import SAGE_SHARE
handbook_file = open(os.path.join(SAGE_SHARE, "handbook_data.txt"),'r')
...

What do you think Nathann?

Vincent

[vdelecroix]

All right, proposition at "public/16541v2"?

By the way Nathann, there is no license issue with copying the whole MOLS table from the handbook?

Vincent

[ncohen]

All right, proposition at "public/16541v2"?

By the way Nathann, there is no license issue with copying the whole MOLS table from the handbook?

You mean that whoever copies/paste Sage's table of MOLS in a paper has to publish it in open access, or that whoever uses our table in a software has to license it with the GPL ? :-P

I take it as a mathematical result. Or 10 000 mathematical results. Of which a good part has been obtained with Sage's functions ;-)

Nathann

[ncohen]

Yo !

Easy solution:

move the file handbook_data.txt into local/share (where most of the raw data belong) and then use

import os.path
from sage.misc.misc import SAGE_SHARE
handbook_file = open(os.path.join(SAGE_SHARE, "handbook_data.txt"),'r')
...

What do you think Nathann?

I don't know if I can just write a file to SAGE_SHARE or if it has to go through a SPKG -_-

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f4f9240

trac #16541: MOLS table : 10 000 integers

[ncohen]

Branch updated with a new "designs" spkg. And the tar.bz2 that should be located in SAGE_ROOT/upstream/ is there :

​http://www.steinertriples.fr/ncohen/tmp/designs-20140630.tar.bz2

Nathann

[vdelecroix]

Hi Nathann,

You are probably right with the spkg. In order to work, the spkg needs to be in standard but the policy is that new spkg goes into optional. Either you write a try/except in the function to test whether the file is here or you ask on sage-devel is everybody is ok to add a trivial text file to the list of standard spkg (the file is really like the database of conway polynomials, si I guess this is fine).

Vincent

[ncohen]

You are probably right with the spkg. In order to work, the spkg needs to be in standard but the policy is that new spkg goes into optional.

I don't think that anybody is stupid enough to tell me that I need to wait one year to add a text file into Sage.

I will write to Sage, if that's a problem.

Nathann

[vbraun]

I'm ok with making it a standard spkg. Note that, by definition, this means that it is installed by default. You need a corresponding entry in build/deps for that.

A more specific name than "designs" would be nice, maybe "combinatorial_designs". But design alone isn't even unique in math, e.g. dessins d'enfants.

A saner way to install the file would be to mkdir -p the target directory and then just copy the file. Blowing the whole directory away is unnecessary and potentially counterproductive in the future, maybe you'll add an optional huge database later on. Not to mention umasks.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f20116d

trac #16541: MOLS table : 10 000 integers

[ncohen]

New commits:

​f20116d

trac #16541: MOLS table : 10 000 integers

[ncohen]

Is that right ?

Nathann

[vdelecroix]

At least for me this is good!

Vincent

[vbraun]

Can you add a == License == section? Data cannot be copyrighted, but the way it is stored in a database is. Not specifying a license means we are not allowed to distribute it.

[ncohen]

And what should I put there ? GPL2 or something ? Is that a correct license for data ?

Nathann

[ncohen]

Besides how can I give a license to a data I just found in a book ? O_o

[vbraun]

GPL or Public Domain is fine. The data is not copyrighted, its the presentation. You choose the license since you curated the electronic database (even if its a bit silly in this case).

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​7e463a9	trac #16541: Merged with beta5
​e282f17	trac #16541: Setting a license for a list of integers

[ncohen]

Okay....

Nathann

[vbraun]

Code still refers to designs/MOLS_table.txt. Also, I'd recommend to use os.path.join to concatenate paths.

[ncohen]

Arg, sorry... And obviously doctests passed because the file was installed on my computed T_T

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​cd90235

trac #16541: New directory

[vbraun]

Its still not installed by default. You also need to define the COMBINATORIAL_DESIGNS variable somewhere, there should be a corresponding line COMBINATORIAL_DESGINS=newest_version combinatorial_designs (or so) in build/install`

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​911c676

trac #16541: make it a default spkg

[ncohen]

ping ?

[ncohen]

Pom Pom Pom ...

[vdelecroix]

Everything went fine on my computer... I set it to positive review.

Vincent

[vbraun]

Fix for the graph database boo-boo in #16735