Opened 7 years ago

Closed 7 years ago

#16539 closed defect (fixed)

FiniteStateMachine.process: Refuse Non-Deterministic Finite State Machines

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.3
Component: finite state machines Keywords:
Cc: dkrenn, skropf Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: ef460c6 (Commits, GitHub, GitLab) Commit: ef460c68b008eb96952c1211f08dd3e4d8d8426f
Dependencies: Stopgaps:

Status badges

Description

Previously, a (more or less) random path was chosen in case of ambiguity in FiniteStateMachine.process. Instead, we now raise a NotImplementedError.

Ideally, process would follow all possible paths. This is #16538, but will need some more time.

As a stop-gap measure, we at least raise a NotImplementedError if the situation occurs.

Change History (3)

comment:1 Changed 7 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Tests passed, code looks fine.

comment:3 Changed 7 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/process-refuse-nondeterministic to ef460c68b008eb96952c1211f08dd3e4d8d8426f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.