Opened 5 years ago

Closed 5 years ago

#16525 closed enhancement (fixed)

IntegerRanger._repr_ now uses ... instead of ..

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: misc Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Martin Albrecht
Report Upstream: N/A Work issues:
Branch: f6a8bff (Commits) Commit: f6a8bffe962f240ec264e5c47dca961aa6d537cc
Dependencies: Stopgaps:

Description

Before

sage: IntegerRange(123,12,-4)
{123, 119, .., 15}

After

sage: IntegerRange(123,12,-4)
{123, 119, ..., 15}

Change History (6)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16525
  • Commit set to 86fdab581c3d78891c49461dc689057d9bbcce02
  • Status changed from new to needs_review

New commits:

86fdab5trac #16525: IntegerRanger._repr_ now uses ... instead of ..

comment:2 Changed 5 years ago by malb

  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

looks okay.

comment:3 Changed 5 years ago by ncohen

Hmmmmm... I'm sorry but I had forgotten to link this patch with #16430 (which is already reviewed+closed but not in a beta yet). This patch adds a doctest which is changed by the patch we have here, so this patch will not pass tests in Volker's beta unless we fix that doctest.

I will push in a second a commit that merges this branch with the branch of #16430, plus a commit that fixes the bug. I just checked that it passed all long tests.

Nathann

comment:4 Changed 5 years ago by git

  • Commit changed from 86fdab581c3d78891c49461dc689057d9bbcce02 to f6a8bffe962f240ec264e5c47dca961aa6d537cc
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

03c1f45trac #16430: Small speedup for OA(None,p^c)
8e8a9f3trac #16430: Merged with 6.3.beta4
162b83ctrac #16430: Many bugfixes
3e01acbtrac #16430: micro improvements
81b9448trac #16430: put back the seealso
b388c60trac #16525: Merged with #16430
f6a8bfftrac #16525: broken doctest

comment:5 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

I just ran "make ptestlong". Soooo given that all this patch does is fix one doctest I set it back to positive_review. Sorry for the trouble.

Nathann

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16525 to f6a8bffe962f240ec264e5c47dca961aa6d537cc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.