Opened 3 years ago

Closed 3 years ago

#16502 closed defect (fixed)

libgap printing to files broken

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.3
Component: graph theory Keywords:
Cc: dimpase, mmarco Merged in:
Authors: Volker Braun Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 6cdd785 (Commits) Commit: 6cdd7851601e2fb7764f91d425c93e4649d2e152
Dependencies: Stopgaps:

Description (last modified by vbraun)

Jerry James reported to me that printing is broken in libGap 4.7.5

sage: libgap.PrintTo('/tmp/out', 'test' * 10000)
sage: os.stat('/tmp/out').st_size
0

New tarball: http://boxen.math.washington.edu/home/vbraun/upstream/libgap-4.7.5.1.tar.gz

Change History (6)

comment:1 Changed 3 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)

I accidentally lost the fix from the previous commit for printing in libgap when preparing libgap 4.7.5. Now with added doctest so it won't happen again.

comment:2 Changed 3 years ago by vbraun

  • Branch set to u/vbraun/libgap_printing_to_files_broken

comment:3 Changed 3 years ago by vbraun

  • Cc dimpase mmarco added
  • Commit set to 6cdd7851601e2fb7764f91d425c93e4649d2e152
  • Status changed from new to needs_review

New commits:

6cdd785Upgrade to libgap 4.7.5.1 and doctest writing to files

comment:4 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:5 Changed 3 years ago by vbraun

  • Reviewers set to Dima Pasechnik

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/vbraun/libgap_printing_to_files_broken to 6cdd7851601e2fb7764f91d425c93e4649d2e152
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.