Opened 7 years ago

Closed 7 years ago

#16498 closed enhancement (fixed)

Improvements to Lie theory documentation

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.3
Component: documentation Keywords: sd58
Cc: sage-combinat, aschilling, bump Merged in:
Authors: Travis Scrimshaw Reviewers: Dan Bump
Report Upstream: N/A Work issues:
Branch: c8f5e49 (Commits) Commit: c8f5e49fd56d7ccbc763f421d2917db8413b8906
Dependencies: Stopgaps:

Description

Add some newer features and results into the Lie theory documentation. This also fixes typos, formatting, and flow.

Change History (12)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/doc/lie_tutorial_cleanup-16498
  • Cc aschilling added
  • Commit set to 94deba276c175bdd157091d56249122bcbafc8d0
  • Keywords sd58 added
  • Status changed from new to needs_review

New commits:

​94deba2Various changes, fixed, additions, and improvements to Lie theory.

comment:2 Changed 7 years ago by bump

The changes are noncontroversial but there is a doctest failure in affine_hw_crystals.rst: 

File "affine_hw_crystals.rst", line 92, in doc.en.thematic_tutorials.lie.affine_hw_crystals
Failed example:
    CM = CartanMatrix([[2, -1, -1,-1],[-1,2,-1,-1],[-1,-1,2,-1],[-1,-1,-1,2]]); M
Exception raised:
[snip]
    NameError: name 'M' is not defined

comment:3 Changed 7 years ago by bump

  • Reviewers set to bump
  • Status changed from needs_review to needs_work

comment:4 Changed 7 years ago by git

  • Commit changed from 94deba276c175bdd157091d56249122bcbafc8d0 to ef88d2aacafeef5e2286382752de5d314b7f98d2

Branch pushed to git repo; I updated commit sha1. New commits:

​f994469Merge branch 'public/doc/lie_tutorial_cleanup-16498' of trac.sagemath.org:sage into pulbic/doc/lie_tutorial_cleanup-16498
​ef88d2aFixed trivial typo with doctest.

comment:5 Changed 7 years ago by tscrim

  • Reviewers changed from bump to Dan Bump
  • Status changed from needs_work to needs_review

Whoops, fixed (and it's now based on 6.3.beta4). Is there anything you want added/expanded upon in here Dan?

comment:6 Changed 7 years ago by bump

I think there are further things that should be in the thematic tutorial but they don't have to go in this patch. For example, the methods of root lattice and weight lattice realizations for affine case. It is best that this be a separate patch because the changes here are noncontroversial and presumably can be merged quickly.

comment:7 follow-up: Changed 7 years ago by bump

  • Status changed from needs_review to positive_review

comment:8 in reply to: ↑ 7 Changed 7 years ago by aschilling

There is a typo in the single KR crystal section:

vertify -> verify

Also, since you mention projections, it should be mentioned which projection (onto what) gives the KR crystals.

comment:9 Changed 7 years ago by git

  • Commit changed from ef88d2aacafeef5e2286382752de5d314b7f98d2 to c8f5e49fd56d7ccbc763f421d2917db8413b8906
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​c8f5e49Fixed typo and added projection image for level 0 crystals.

comment:10 Changed 7 years ago by tscrim

Fixed and done. If you're happy with the change, please set this back to positive review.

comment:11 Changed 7 years ago by aschilling

  • Status changed from needs_review to positive_review

comment:12 Changed 7 years ago by vbraun

  • Branch changed from public/doc/lie_tutorial_cleanup-16498 to c8f5e49fd56d7ccbc763f421d2917db8413b8906
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.