Opened 8 years ago

Closed 7 years ago

#16493 closed defect (fixed)

Sage --dev tests broken for non-interactive shells

Reported by: robertwb Owned by: rws
Priority: major Milestone: sage-6.4
Component: misc Keywords:
Cc: Merged in:
Authors: Robert Bradshaw Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 52d2d2f (Commits, GitHub, GitLab) Commit: 52d2d2f55340548c212ca1f4e3b25d3db3f06b0c
Dependencies: Stopgaps:

Status badges

Description

The manifests itself on various buildbots, giving errors like

File "/scratch/scoder/jenkins/sage/sage-git/src/sage/tests/cmdline.py", line 467, in sage.tests.cmdline.test_executable
Failed example:
    ret, err
Expected:
    (0, '')
Got:
    (1, 'Traceback (most recent call last):
  File "/scratch/scoder/jenkins/sage/sage-git/src/bin/sage-dev", line 334, in <module>
    parser = parser_from_object(DEV)
  File "/scratch/scoder/jenkins/sage/sage-git/src/bin/sage-dev", line 258, in parser_from_object
    parser = argparse.ArgumentParser(*args, **kwds)
  File "/scratch/scoder/jenkins/sage/sage-git/local/lib/python/argparse.py", line 1600, in __init__
    help=_(\'show this help message and exit\'))
  File "/scratch/scoder/jenkins/sage/sage-git/local/lib/python/argparse.py", line 1291, in add_argument
    self._get_formatter()._format_args(action, None)
  File "/scratch/scoder/jenkins/sage/sage-git/local/lib/python/argparse.py", line 2314, in _get_formatter
    return self.formatter_class(prog=self.prog)
  File "/scratch/scoder/jenkins/sage/sage-git/src/bin/sage-dev", line 37, in __init__
    width=DEV._sagedev._UI._get_dimensions()[1]-2, *args, **kwds)
  File "/scratch/scoder/jenkins/sage/sage-git/local/lib/python2.7/site-packages/sage/dev/cmd_line_interface.py", line 264, in _get_dimensions
    fd = os.open(os.ctermid(), os.O_RDONLY)
OSError: [Errno 6] No such device or address: \'/dev/tty\'

Change History (10)

comment:1 Changed 8 years ago by robertwb

  • Branch set to u/robertwb/ticket/16493
  • Created changed from 06/18/14 04:55:23 to 06/18/14 04:55:23
  • Modified changed from 06/18/14 04:55:23 to 06/18/14 04:55:23

comment:2 Changed 8 years ago by robertwb

  • Commit set to 088a1bd357d9cdd4593128768acffd582b49c0a4
  • Status changed from new to needs_review

New commits:

088a1bdFix sage --dev test for non-interactive sessions.

comment:3 Changed 8 years ago by rws

  • Owner changed from (none) to rws
  • Reviewers set to Ralf Stephan

Should be good. Passes on desktop Sage.

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 7 years ago by jdemeyer

  • Component changed from doctest framework to misc

comment:6 Changed 7 years ago by robertwb

Ralf, is that a positive review?

comment:7 Changed 7 years ago by chapoton

  • Branch changed from u/robertwb/ticket/16493 to public/ticket/16493
  • Commit changed from 088a1bd357d9cdd4593128768acffd582b49c0a4 to 52d2d2f55340548c212ca1f4e3b25d3db3f06b0c

Now using the new-style doctest continuation.


New commits:

65c0c91Merge branch 'u/robertwb/ticket/16493' of trac.sagemath.org:sage into 6.4.b6
52d2d2ftrac #16493 new style of doctest continuation

comment:8 Changed 7 years ago by robertwb

Ah, thanks. Positive review for the new style continuation.

comment:9 Changed 7 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:10 Changed 7 years ago by vbraun

  • Branch changed from public/ticket/16493 to 52d2d2f55340548c212ca1f4e3b25d3db3f06b0c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.