Opened 6 years ago

Closed 5 years ago

#16479 closed enhancement (fixed)

package for pip the Python installer

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.4
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Andrey Novoseltsev, William Stein
Report Upstream: N/A Work issues:
Branch: 2a0798d (Commits) Commit: 2a0798df798d1086fb2f1e2a193cf43bc1b86d1e
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

As discussed on this sage-devel thread it would be nice to have pip as a package.

upstream tarball: https://pypi.python.org/packages/source/p/pip/pip-1.5.6.tar.gz

Change History (19)

comment:1 Changed 6 years ago by vdelecroix

  • Description modified (diff)

comment:2 Changed 6 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/16479
  • Commit set to 038ae9caffb0cd949b2b686b81bb010cd7f3df3a
  • Status changed from new to needs_review

New commits:

038ae9ctrac #16479: pip package

comment:3 Changed 6 years ago by vdelecroix

  • Status changed from needs_review to needs_work

currently does not work...

comment:4 Changed 6 years ago by vdelecroix

  • Description modified (diff)

comment:5 Changed 6 years ago by vdelecroix

  • Description modified (diff)

comment:6 Changed 6 years ago by git

  • Commit changed from 038ae9caffb0cd949b2b686b81bb010cd7f3df3a to 536c3cbb8b7d4a933770be1a605bc5fbbb1ba8d7

Branch pushed to git repo; I updated commit sha1. New commits:

536c3cbtrac #16479: pip package

comment:7 Changed 6 years ago by vdelecroix

  • Status changed from needs_work to needs_review

Finally I found out a tarball!


New commits:

536c3cbtrac #16479: pip package

comment:8 Changed 6 years ago by was

English remarks:

  • "This package install pip." --> "This package installs pip."
  • "Custom license compatible GPLv3+." --> "Custom license that is compatible with GPLv3+."

This looks good to me, but I can't even figure out how to review tickets anymore.

comment:9 Changed 6 years ago by git

  • Commit changed from 536c3cbb8b7d4a933770be1a605bc5fbbb1ba8d7 to 5dc530f62e90534b5f950f371b8e412dcb2194c4

Branch pushed to git repo; I updated commit sha1. New commits:

5dc530ftrac #16470: reviewer comment 1

comment:10 Changed 5 years ago by novoselt

How is it supposed to work?

novoselt@sage:~/sage$ sage -i pip
Found local metadata for pip-1.5.6
Attempting to download package pip-1.5.6
>>> Trying to download http://www.sagemath.org/packages/upstream/pip/pip-1.5.6.tar.gz
[Traceback (most recent call last):
  File "<stdin>", line 35, in <module>
  File "/home/novoselt/sage/local/lib/python/urllib.py", line 240, in retrieve
    fp = self.open(url, data)
  File "/home/novoselt/sage/local/lib/python/urllib.py", line 208, in open
    return getattr(self, name)(url)
  File "/home/novoselt/sage/local/lib/python/urllib.py", line 359, in open_http
    return self.http_error(url, fp, errcode, errmsg, headers)
  File "/home/novoselt/sage/local/lib/python/urllib.py", line 376, in http_error
    return self.http_error_default(url, fp, errcode, errmsg, headers)
  File "<stdin>", line 17, in http_error_default
IOError: [Errno 404] Not Found: '//www.sagemath.org/packages/upstream/pip/pip-1.5.6.tar.gz'
Error: failed to download package pip-1.5.6
novoselt@sage:~/sage$ sage -i https://pypi.python.org/packages/source/p/pip/pip-1.5.6.tar.gz
Attempting to download package pip-1.5.6.tar.gz
>>> Trying to download https://pypi.python.org/packages/source/p/pip/pip-1.5.6.tar.gz
[............................................................]
pip-1.5.6.tar.gz
====================================================
Extracting package /home/novoselt/sage/upstream/pip-1.5.6.tar.gz
-rw-r--r-- 1 novoselt novoselt 938120 Aug  6 17:15 /home/novoselt/sage/upstream/pip-1.5.6.tar.gz
Finished extraction
/home/novoselt/sage/src/bin/sage-spkg: line 596: cd: pip-1.5.6.tar.gz: No such file or directory
Error: after extracting, the directory pip-1.5.6.tar.gz does not exist

Doing sage -i pip after this successful download but failed installation works.

comment:11 Changed 5 years ago by vdelecroix

Hi Andrey,

You should first download pip from the link in the description of the ticket. Then you have to put it in SAGE_ROOT/upstream/. Then you can do the command you tried.

Best, Vincent

comment:12 Changed 5 years ago by novoselt

  • Reviewers set to Andrey Novoseltsev, William Stein
  • Status changed from needs_review to positive_review

OK, positive review in this case. Are we going to actually make this a standard package?

comment:13 Changed 5 years ago by vdelecroix

I asked the question on this sage-devel thread.

Vincent

comment:14 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:15 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_info

What do you mean by "custom license" in SPKG.txt, its MIT according to pypi.

comment:16 Changed 5 years ago by git

  • Commit changed from 5dc530f62e90534b5f950f371b8e412dcb2194c4 to 2a0798df798d1086fb2f1e2a193cf43bc1b86d1e

Branch pushed to git repo; I updated commit sha1. New commits:

2a0798dtrac #16479: set license to MIT

comment:17 Changed 5 years ago by vdelecroix

  • Status changed from needs_info to needs_review

comment:18 Changed 5 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:19 Changed 5 years ago by vbraun

  • Branch changed from u/vdelecroix/16479 to 2a0798df798d1086fb2f1e2a193cf43bc1b86d1e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.