Opened 3 years ago

Last modified 13 months ago

#16448 needs_work enhancement

Genus 1 Jacobi forms

Reported by: mraum Owned by:
Priority: major Milestone: sage-7.3
Component: modular forms Keywords:
Cc: Merged in:
Authors: Martin Westerholt-Raum Reviewers:
Report Upstream: N/A Work issues:
Branch: public/ticket/16448 (Commits) Commit: 62c6fe81762ed7c39f0bc20bfa1d99f6134e73a4
Dependencies: Stopgaps:

Description

Implement Jacobi forms with lattice index as in [Raum, Computing Genus 1 Jacobi Forms]. This is related to #15758, but does not depend on it. This allows to also compute vector valued modular forms for Weyl representations attached to discriminant forms.

Change History (18)

comment:1 Changed 3 years ago by mraum

  • Branch set to u/mraum/ticket/16448
  • Created changed from 06/05/14 16:44:23 to 06/05/14 16:44:23
  • Modified changed from 06/05/14 16:44:23 to 06/05/14 16:44:23

comment:2 Changed 3 years ago by mraum

  • Commit set to 2d492fe7cfcc98249af2f4ec3ccc223ec0d66c7e
  • Status changed from new to needs_review

Last 10 new commits:

9f3e2a8Update tests for vector valued modular forms.
ccd6accUpdate jacobi/all.py.
ff2c81fCorrect code for classical weak Jacobi forms.
3025276Correct tests for vector valued modular forms.
d5099cfCorrect typos.
f2c4e2aTypo in doctests.
a38598fUpdate doctests.
6ca62d1Correct typos in classical weak Jacobi form tests.
24c8c24Fix doctests for classical weak Jacobi forms.
2d492feFix doctests for classical Jacobi forms.

comment:3 Changed 3 years ago by git

  • Commit changed from 2d492fe7cfcc98249af2f4ec3ccc223ec0d66c7e to 0d20eac89e73b28d7e1f3c14d8bde27617db975f

Branch pushed to git repo; I updated commit sha1. New commits:

0514c50Add global examples.
4e631c2Add all to __init__.py
ff48b23Add Jacobi forms to documentation.
8cc221fRefactor index reduction function.
4b7c27fAdd import for Jacobi forms.
0d20eacCorrect test for Jacobi forms.

comment:4 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work
  • Work issues set to add missing doctests

comment:5 Changed 3 years ago by git

  • Commit changed from 0d20eac89e73b28d7e1f3c14d8bde27617db975f to 67c13993df78dfe3cf92fb85b40bd26fbd78993d

Branch pushed to git repo; I updated commit sha1. New commits:

d49e1dcRemove import of mpmath.
c82a8c0Add doctest to higherrank.py.
67c1399Add doctests to higherrank_dimension.py.

comment:6 Changed 3 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 3 years ago by git

  • Commit changed from 67c13993df78dfe3cf92fb85b40bd26fbd78993d to 061f1365e01d594da85025dbe1e56a28479625ae

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

c7968aeFix doctests for classical Jacobi forms.
3451307Add global examples.
26959b7Add all to __init__.py
c342417Refactor index reduction function.
9558755Correct test for Jacobi forms.
9e10960Remove import of mpmath.
770d6a3Add doctest to higherrank.py.
22f23e7Add doctests to higherrank_dimension.py.
c887b1cCorrect doctests of Jacobi form tests
061f136Adopt to new spacing in doctests.

comment:8 Changed 3 years ago by mraum

  • Authors changed from Martin Raum to Martin Westerholt-Raum
  • Status changed from needs_work to needs_review
  • Work issues add missing doctests deleted

comment:9 Changed 2 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-6.6
  • Status changed from needs_review to needs_work

There is one failing doctest

sage -t --long src/sage/modular/jacobi/higherrank_dimension.py
**********************************************************************
File "src/sage/modular/jacobi/higherrank_dimension.py", line 61, in sage.modular.jacobi.higherrank_dimension.jacobi_dimension
Failed example:
    assert all( len(_classical_jacobi_forms_as_weak_jacobi_forms(k, m)) == jacobi_dimension(k, matrix([[2 * m]])) for k in range(8, 16) for m in range(1, 10) ) 

comment:10 Changed 2 years ago by chapoton

  • Branch changed from u/mraum/ticket/16448 to public/ticket/16448
  • Commit changed from 061f1365e01d594da85025dbe1e56a28479625ae to 3ccfbece3761ef47096f8a1832301cdd8c88c389

I have made a commit that includes the doc into sage standard doc (I had to correct a sphinx error)


New commits:

7c4edd9Merge branch 'u/mraum/ticket/16448' into 6.6.b3
3ccfbectrac #16449 inclusion into sage doc, plus correction to the doc

comment:11 Changed 2 years ago by git

  • Commit changed from 3ccfbece3761ef47096f8a1832301cdd8c88c389 to 5293a865dbe586928e7ed9f97a567e96eb7977a4

Branch pushed to git repo; I updated commit sha1. New commits:

5293a86trac #16448 more doc improvements

comment:12 Changed 2 years ago by git

  • Commit changed from 5293a865dbe586928e7ed9f97a567e96eb7977a4 to 6d023b36f45b245ae4f71e9bb255ee40e62a7291

Branch pushed to git repo; I updated commit sha1. New commits:

6d023b3Merge branch 'public/ticket/16448' of trac.sagemath.org:sage into 16448

comment:13 Changed 2 years ago by chapoton

  • Milestone changed from sage-6.6 to sage-6.8

comment:14 Changed 2 years ago by git

  • Commit changed from 6d023b36f45b245ae4f71e9bb255ee40e62a7291 to 23d2ce8e1466ed8c5612d13564c21a20d147b035

Branch pushed to git repo; I updated commit sha1. New commits:

8a6b971Merge branch 'public/ticket/16448' into 6.8.b6
23d2ce8trac #16448 pyflakes and pep8 work

comment:15 Changed 15 months ago by git

  • Commit changed from 23d2ce8e1466ed8c5612d13564c21a20d147b035 to a3c384fc367e58c39a0f82751a98f9b727684bc1

Branch pushed to git repo; I updated commit sha1. New commits:

43d3e12Merge branch 'public/ticket/16448' into 7.1
a3c384ftrac #16448 trying to repair the branch

comment:16 Changed 13 months ago by git

  • Commit changed from a3c384fc367e58c39a0f82751a98f9b727684bc1 to a0ffe6363aea70a4f8a04822f9cc4c815edc9a50

Branch pushed to git repo; I updated commit sha1. New commits:

47a7968Merge branch 'public/ticket/16448' into 7.2.rc2
a0ffe63trac 16448 modernising imports

comment:17 Changed 13 months ago by git

  • Commit changed from a0ffe6363aea70a4f8a04822f9cc4c815edc9a50 to 62c6fe81762ed7c39f0bc20bfa1d99f6134e73a4

Branch pushed to git repo; I updated commit sha1. New commits:

62c6fe8trac 16448 changing import again

comment:18 Changed 13 months ago by chapoton

  • Milestone changed from sage-6.8 to sage-7.3
Note: See TracTickets for help on using tickets.