Opened 7 years ago

Closed 7 years ago

Last modified 17 months ago

#16438 closed enhancement (fixed)

Use d3js package if available

Reported by: tmonteil Owned by: tmonteil
Priority: major Milestone: sage-6.3
Component: graph theory Keywords: d3.js, sdl
Cc: ncohen, bonfroy Merged in:
Authors: Thierry Monteil Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 1ce71b1 (Commits) Commit: 1ce71b1fe2b8240a5475f07759feff14df6441d3
Dependencies: #14953, #16434 Stopgaps:

Description (last modified by tmonteil)

The aim of this ticket is to use the package provided by #16434 when drawing graphs, instead of fetching d3.min.js online (see #14953).

Change History (10)

comment:1 Changed 7 years ago by tmonteil

  • Cc ncohen bonfroy added
  • Component changed from PLEASE CHANGE to graph theory
  • Dependencies set to #14953, #16434
  • Description modified (diff)
  • Keywords d3.js added
  • Owner changed from (none) to tmonteil
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 7 years ago by tmonteil

  • Branch set to u/tmonteil/use_d3js_package_if_available

comment:3 Changed 7 years ago by tmonteil

  • Commit set to d5c364708a675590955d4f8fe374d2658fe4abdc
  • Status changed from new to needs_review

New commits:

89bbeceGraph drawing in javascript using d3.js
465f9dbtrac #14953 cleanup, pep8 and details
84b44abGit directory layout
44265a5trac #14953: Merged with 6.3.beta0
9cbcc36trac #14953: Merged with 6.3.beta2
76acf85trac #14953: Moving the .html to EXT_CODE and using DOCTEST_MODE
d5c364716438 : use d3js spkg if available

comment:4 Changed 7 years ago by tmonteil

Only the last commit is to be reviewed, the other commits come from #14953 which this ticket depends on (positively reviewed but not merged yet).

comment:5 Changed 7 years ago by git

  • Commit changed from d5c364708a675590955d4f8fe374d2658fe4abdc to 02c10912bb72fd996d6fe668c4c0781837addae8

Branch pushed to git repo; I updated commit sha1. New commits:

02c1091Merge branch 'develop' into t/16438/use_d3js_package_if_available

comment:6 Changed 7 years ago by git

  • Commit changed from 02c10912bb72fd996d6fe668c4c0781837addae8 to 1ce71b1fe2b8240a5475f07759feff14df6441d3

Branch pushed to git repo; I updated commit sha1. New commits:

1ce71b1#16438 move warning from code to documentation.

comment:7 Changed 7 years ago by tmonteil

I removed the warn() command which might be annoying, instead i added warnings in the doc.

Last edited 7 years ago by tmonteil (previous) (diff)

comment:8 Changed 7 years ago by ncohen

  • Authors set to Thierry Monteil
  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Excellent ! Good to go then :-)

Nathann

comment:9 Changed 7 years ago by vbraun

  • Branch changed from u/tmonteil/use_d3js_package_if_available to 1ce71b1fe2b8240a5475f07759feff14df6441d3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 17 months ago by tmonteil

  • Keywords sdl added
Note: See TracTickets for help on using tickets.