Opened 5 years ago

Closed 5 years ago

#16423 closed enhancement (fixed)

Table of MOLS from the handbook and comparison with Sage

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix, knsam, dimpase, brett Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 0a7d853 (Commits) Commit: 0a7d853bf758ac7abce1acfe54e18c5ea784d21f
Dependencies: #16347 Stopgaps:

Description (last modified by ncohen)

With this branch we have a MOLS_table function which displays what Sage can handle, and also compare it with what the Handbook of Combinatorial Designs (2ed) claims.

We seem to be rather far but I have several construction that somehow make the gap smaller. But there is a lot to review already :-P

Nathan

Change History (25)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16423
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 765898988ad40812d22d63fe6deb59ad47d929a3

Branch pushed to git repo; I updated commit sha1. New commits:

7658989trac #16423: Table of MOLS from the handbook and comparison with Sage

comment:3 Changed 5 years ago by vdelecroix

Indeed, a lot of minus... but at least two pluses!

Vincent

comment:4 Changed 5 years ago by ncohen

Don't worry about the minuses... They are an endangered species.

Nathann

comment:5 Changed 5 years ago by vdelecroix

Hi Nathann,

In u/vdelecroix/16423 I simplified some of the string formatting and aligned the Handbook table. If you are happy with it, set to positive review.

Vincent

comment:6 Changed 5 years ago by ncohen

I align a part of the alignment. Aaaaaaaaand set the ticket to positive review hoping that you will have nothing against it :-P

Nathan

P.S. : and now that this branch is positvely reviewed I will have to rebase all other branches above it, as they will all conflict with the new MOLS table.....

comment:7 Changed 5 years ago by git

  • Commit changed from 765898988ad40812d22d63fe6deb59ad47d929a3 to c2a4dc04a68fc7c73f8a5580018ca50e1838c263

Branch pushed to git repo; I updated commit sha1. New commits:

1d65043trac #16423: tiny code improvement and alignment
c2a4dc0trac #16423: Aligning the alignment

comment:8 Changed 5 years ago by ncohen

  • Dependencies set to #16347, #16361

Okay, let's do it the other way around otherwise it will be a mess....

Nathann

comment:9 Changed 5 years ago by ncohen

  • Dependencies changed from #16347, #16361 to #16347

comment:10 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

comment:11 Changed 5 years ago by ncohen

  • Description modified (diff)

comment:12 Changed 5 years ago by ncohen

  • Description modified (diff)

comment:13 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:14 Changed 5 years ago by git

  • Commit changed from c2a4dc04a68fc7c73f8a5580018ca50e1838c263 to c6615b871563dd6fcd0379e82cb7dc63f7864c3a

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

fc6de73trac #16295: Merged with 6.3.beta1
b9f8b03trac #16295: bugfix in wilson's construction
00ee241trac #16347: Wilson's constructions of OA with 2 truncated groups
c1bb903trac #16347: Merged with #16391
a4554f5trac #16347: Genelarized Wilson construction
f969003trac #16356: MOLS for n=18,57,154,276,298,342
20ef216trac #16361: OA(7,66), OA(7,68), OA(8,69), OA(7,74) and OA(8,76)
dcf5843trac #16373: OA(18,273), OA(12,474), OA(33,993)
2e46351trac #16347: Merged with #16373
c6615b8trac #16423: Merged with #16347

comment:15 Changed 5 years ago by ncohen

  • Description modified (diff)
  • Status changed from needs_work to needs_review

Merged with #16347. Here is the new table of differences (without the construction that are still on my computer only)

       0   1   2   3   4   5   6   7   8   9  10  11  12  13  14  15  16  17  18  19
    ________________________________________________________________________________ 
  0|                                                           +               +     
 20|                                                                                 
 40|                                                                                 
 60|   +                                                                             
 80|                                           -   -                                 
100|                                                   -               -       -     
120|   -                                                   -       -                 
140|                                                               -           -     
160|   -               -                                               -             
180|                       -               -                                         
200|       -               -           -                                             
220|                   -                           -                       -         
240|                                                       -   -                   - 
260|           -               -       -                           -               - 
280|                                                                                 
300|           -   -                                           -                     
320|                                       -                   -       -             
340|                                                   -           -   -   -         
360|   -                   -                       -   -       -   -       -         
380|                                                       -                   -     

comment:16 Changed 5 years ago by git

  • Commit changed from c6615b871563dd6fcd0379e82cb7dc63f7864c3a to a428b8ff883ad409097cfbdc3d61a6d0a70cc13b

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ec26ca2trac #16388: a missing one in BIBD_from_TD
79178b6trac #16388: (v,k,1)-BIBD instead of BIBD(v,k,1)
02ecf51trac #16361: Merged with #16388
5d4607atrac #16361: Don't re-raise the exceptions
541269btrac #16373: merge #16361
004833atrac #16347: Wilson's construction with two truncated groups
2a9bd05trac #16423: Table of MOLS from the handbook and comparison with Sage
41f8a32trac #16423: tiny code improvement and alignment
d6a7db2trac #16423: Aligning the alignment
a428b8ftrac #16423: Broken doctests

comment:17 Changed 5 years ago by vdelecroix

Hi,

I did the rebase over #16347 at public/16423. It looks good to me, just do a double check.

Vincent

comment:18 Changed 5 years ago by ncohen

There are two commits containing Wilson's construction with two truncated groups in your branch

~/sage$ git log --oneline HEAD ^d
e5de914 trac #16423: merge #16347
0175134 trac #16347: doc + simplifications
8ebd21b trac #16347: use is_sum_of_squares_pyx instead of two_squares
828ff22 trac #16437: cut the branches in W. dec. with two trunc. blocks
0fa89d5 trac #16347: Wilson's construction with two truncated groups
81b9448 trac #16430: put back the seealso
3e01acb trac #16430: micro improvements
162b83c trac #16430: Many bugfixes
8e8a9f3 trac #16430: Merged with 6.3.beta4
a428b8f trac #16423: Broken doctests
d6a7db2 trac #16423: Aligning the alignment
41f8a32 trac #16423: tiny code improvement and alignment
2a9bd05 trac #16423: Table of MOLS from the handbook and comparison with Sage
004833a trac #16347: Wilson's construction with two truncated groups
03c1f45 trac #16430: Small speedup for OA(None,p^c)

If you don't mind, I will cherry-pick the commits from the current branch on top of #16347.

Nathann

comment:19 Changed 5 years ago by vdelecroix

Argh! What did I do?!

If you know what to do, do it!

Vincent

comment:20 Changed 5 years ago by ncohen

Here it is.

Nathann

comment:21 Changed 5 years ago by git

  • Commit changed from a428b8ff883ad409097cfbdc3d61a6d0a70cc13b to 0a7d853bf758ac7abce1acfe54e18c5ea784d21f

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

3e01acbtrac #16430: micro improvements
81b9448trac #16430: put back the seealso
0fa89d5trac #16347: Wilson's construction with two truncated groups
828ff22trac #16437: cut the branches in W. dec. with two trunc. blocks
8ebd21btrac #16347: use is_sum_of_squares_pyx instead of two_squares
0175134trac #16347: doc + simplifications
9ff5062trac #16423: Table of MOLS from the handbook and comparison with Sage
e64be98trac #16423: tiny code improvement and alignment
e948cf6trac #16423: Aligning the alignment
0a7d853trac #16423: Broken doctests

comment:22 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to positive_review

Great!

comment:23 Changed 5 years ago by ncohen

Thanks !

Nathann

comment:24 Changed 5 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

comment:25 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16423 to 0a7d853bf758ac7abce1acfe54e18c5ea784d21f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.