Opened 7 years ago
Closed 6 years ago
#16404 closed enhancement (duplicate)
logic error in code of _gomory_hu_tree
Reported by: | foosterhof | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-duplicate/invalid/wontfix |
Component: | graph theory | Keywords: | gomory-hu tree gomory hu |
Cc: | Merged in: | ||
Authors: | Reviewers: | Frédéric Chapoton | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/foosterhof/ticket/16404 (Commits, GitHub, GitLab) | Commit: | 217568501d25e3370f546a54e5c2a265298f5d70 |
Dependencies: | Stopgaps: |
Description
The virtual (fake) vertex g2_v is added to g1, even though I think it makes alot more sense to add it to g2.
As far as I know, it does not create bugs or incorrect results, as add_edge adds the vertex if it does not exist, but it would seem rather unfavourable to keep such an error existent.
Change History (7)
comment:1 Changed 7 years ago by
- Branch set to u/foosterhof/ticket/16404
- Created changed from 05/27/14 13:40:16 to 05/27/14 13:40:16
- Modified changed from 05/27/14 13:40:16 to 05/27/14 13:40:16
comment:2 Changed 7 years ago by
- Commit set to 217568501d25e3370f546a54e5c2a265298f5d70
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
You should try to add a doctest that tests that this change is correct, if possible.
comment:4 Changed 7 years ago by
- Report Upstream changed from N/A to None of the above - read trac for reasoning.
This fix is redundant as I fixed it immediately when fixing ticket #16475. Can thus be closed or removed, or anything the likes.
Florian
comment:5 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:6 Changed 6 years ago by
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
- Report Upstream changed from None of the above - read trac for reasoning. to N/A
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, then let us say that this is a duplicate
comment:7 Changed 6 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fixed logic error in Gomory-Hu tree algorithm