Opened 5 years ago

Closed 5 years ago

#16390 closed defect (fixed)

in src/bin/sage handle -patchbot option earlier

Reported by: rws Owned by:
Priority: major Milestone: sage-6.3
Component: scripts Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: c017fd5 (Commits) Commit: c017fd54bd50cc15373ea120adc4938a8d9dfebd
Dependencies: Stopgaps:

Description (last modified by rws)

As explained in https://github.com/robertwb/sage-patchbot/issues/35 and http://trac.sagemath.org/ticket/16377#comment:11, patchbot when started with sage -patchbot will clobber your Sage installation because the environment is changed before patchbot is started.

vbraun: "The handling of the -patchbot switch in src/bin/sage needs to be moved above the "Source sage-env" step, so it is done before the environment is changed."

Change History (9)

comment:1 Changed 5 years ago by rws

  • Description modified (diff)

comment:2 Changed 5 years ago by rws

  • Description modified (diff)

comment:3 Changed 5 years ago by rws

  • Description modified (diff)
  • Summary changed from remove -patchbot option to sage to in src/bin/SAGE handle -patchbot option earlier

comment:4 Changed 5 years ago by rws

  • Branch set to u/rws/in_src_bin_sage_handle__patchbot_option_earlier

comment:5 Changed 5 years ago by rws

  • Commit set to c017fd54bd50cc15373ea120adc4938a8d9dfebd
  • Status changed from new to needs_review

This appears to work and, in conjunction with a fix for the setuptools problem, allows patchbot to test unsafe tickets successfully.


New commits:

c017fd516390: move up patchbot handling

comment:6 Changed 5 years ago by rws

  • Summary changed from in src/bin/SAGE handle -patchbot option earlier to in src/bin/sage handle -patchbot option earlier

comment:7 Changed 5 years ago by rws

  • Authors set to Ralf Stephan

comment:8 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/rws/in_src_bin_sage_handle__patchbot_option_earlier to c017fd54bd50cc15373ea120adc4938a8d9dfebd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.