Opened 5 years ago

Closed 5 years ago

#16388 closed enhancement (fixed)

Specify the values of k,n in the exceptions

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix, knsam, brett Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 79178b6 (Commits) Commit: 79178b62b55c9d38b4ee015118e1cbc6acefb8f8
Dependencies: Stopgaps:

Description

Simple thing, that can be useful for recursive constructions. You don't always know what "this" design exactly is in complicated functions.

Nathann

Change History (16)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16388
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 767e0911107e5b374ad182acd0e5dac79ae8c874

Branch pushed to git repo; I updated commit sha1. New commits:

767e091trac #16388: Specify the values of k,n in the exceptions

comment:3 Changed 5 years ago by vdelecroix

Hi Nathann,

All right, why not doing it for BIBD as well?

Vincent

comment:4 Changed 5 years ago by ncohen

Indeed. You can add a commit.

Nathann

comment:5 follow-up: Changed 5 years ago by vdelecroix

I can do that, but I do care about merge conflicts with other tickets.

comment:6 in reply to: ↑ 5 Changed 5 years ago by ncohen

I can do that, but I do care about merge conflicts with other tickets.

Caring is good. Do you have a specific ticket in mind ?

Nathann

comment:7 follow-up: Changed 5 years ago by vdelecroix

For example #16347 (Wilson's constructions of OA with 2 truncated groups) modifies bibd.py

comment:8 in reply to: ↑ 7 Changed 5 years ago by ncohen

For example #16347 (Wilson's constructions of OA with 2 truncated groups) modifies bibd.py

Indeed. You can see that none of the lines near where the exceptions are raised or doctested are touched, so this is safe.

Nathann

comment:9 follow-up: Changed 5 years ago by vdelecroix

The two commits at u/vdelecroix/16388 take care of BIBD. All test pass. Can set to positive review if you like.

Vincent

comment:10 in reply to: ↑ 9 Changed 5 years ago by ncohen

Yo !

The two commits at u/vdelecroix/16388 take care of BIBD. All test pass. Can set to positive review if you like.

I added a small commit as one usually writes (v,k,lambda)-BIBD.

Nathann

comment:11 Changed 5 years ago by git

  • Commit changed from 767e0911107e5b374ad182acd0e5dac79ae8c874 to 79178b62b55c9d38b4ee015118e1cbc6acefb8f8

Branch pushed to git repo; I updated commit sha1. New commits:

a460169merge Sage version 6.3.beta3
c365a39trac #16388: use format for OA + specify (k,n) for BIBD
ec26ca2trac #16388: a missing one in BIBD_from_TD
79178b6trac #16388: (v,k,1)-BIBD instead of BIBD(v,k,1)

comment:12 Changed 5 years ago by ncohen

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

By the way the modifications you did to the exception of OA/TD will probably cost a LOT of conflicts.

Just mentionning it because you said that you cared.

Nathann

comment:13 Changed 5 years ago by ncohen

Oh, my mistake. Those modifications cannot hurt more than the patch did before you wrote this commit. Sorry for that.

I hope I had conflicts in mind when I first wrote it. Otherwise I will pay it.

Nathann

comment:14 follow-up: Changed 5 years ago by vdelecroix

The terminology is not understandable:

  • MOLS(n,k) but TD(k,n)
  • (v,k,lambda)-BIBD but TD(v,k,lambda)

good luck for your future merges... (now you are used to it ;-P)

Vincent

comment:15 in reply to: ↑ 14 Changed 5 years ago by ncohen

Yo !

The terminology is not understandable:

I just sent you "Combinatorial Designs: Construction and Analysis" from Douglas Stinson which uses (v,k,lambda)-BIBD, TD(k,n) and OA(k,n). I believed that the Handbook of Combinatorial Designs did the same but they actually write BIBD(v,k,lambda). Their purpose was probably to unify notations, given that (v,k,lambda)-BIBD is a pretty common :

http://www.maths.qmul.ac.uk/~leonard/repeated11.pdf http://www.argilo.net/files/bibd.pdf

You will also find other occurrences of this naming in the references of the Handbook.

Othey guys say 2-(v,k,lambda) design.

  • MOLS(n,k) but TD(k,n)
  • (v,k,lambda)-BIBD but TD(v,k,lambda)

Two remarks :

  • MOLS(n,k) does not appear in Sage's code
  • It is true that the constructor of MOLS takes first a n then an k as input. It is true that it can lead to mistakes, and perhaps we should change it.
  • If you insist on using BIBD(v,k,lambda) it can be done but it has to be a global change as some pages, eg http://sagemath.org/doc/reference/combinat/sage/combinat/designs/bibd.html already use this terminology. Same for PBD.

good luck for your future merges... (now you are used to it ;-P)

Nathann

Last edited 5 years ago by ncohen (previous) (diff)

comment:16 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16388 to 79178b62b55c9d38b4ee015118e1cbc6acefb8f8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.