Opened 7 years ago
Closed 6 years ago
#16388 closed enhancement (fixed)
Specify the values of k,n in the exceptions
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.3 |
Component: | combinatorial designs | Keywords: | |
Cc: | vdelecroix, knsam, brett | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | 79178b6 (Commits) | Commit: | 79178b62b55c9d38b4ee015118e1cbc6acefb8f8 |
Dependencies: | Stopgaps: |
Description
Simple thing, that can be useful for recursive constructions. You don't always know what "this" design exactly is in complicated functions.
Nathann
Change History (16)
comment:1 Changed 7 years ago by
- Branch set to u/ncohen/16388
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Commit set to 767e0911107e5b374ad182acd0e5dac79ae8c874
comment:3 Changed 6 years ago by
Hi Nathann,
All right, why not doing it for BIBD as well?
Vincent
comment:4 Changed 6 years ago by
Indeed. You can add a commit.
Nathann
comment:5 follow-up: ↓ 6 Changed 6 years ago by
I can do that, but I do care about merge conflicts with other tickets.
comment:6 in reply to: ↑ 5 Changed 6 years ago by
I can do that, but I do care about merge conflicts with other tickets.
Caring is good. Do you have a specific ticket in mind ?
Nathann
comment:7 follow-up: ↓ 8 Changed 6 years ago by
For example #16347 (Wilson's constructions of OA with 2 truncated groups) modifies bibd.py
comment:8 in reply to: ↑ 7 Changed 6 years ago by
For example #16347 (Wilson's constructions of OA with 2 truncated groups) modifies bibd.py
Indeed. You can see that none of the lines near where the exceptions are raised or doctested are touched, so this is safe.
Nathann
comment:9 follow-up: ↓ 10 Changed 6 years ago by
The two commits at u/vdelecroix/16388 take care of BIBD. All test pass. Can set to positive review if you like.
Vincent
comment:10 in reply to: ↑ 9 Changed 6 years ago by
Yo !
The two commits at u/vdelecroix/16388 take care of BIBD. All test pass. Can set to positive review if you like.
I added a small commit as one usually writes (v,k,lambda)-BIBD.
Nathann
comment:11 Changed 6 years ago by
- Commit changed from 767e0911107e5b374ad182acd0e5dac79ae8c874 to 79178b62b55c9d38b4ee015118e1cbc6acefb8f8
comment:12 Changed 6 years ago by
- Reviewers set to Vincent Delecroix
- Status changed from needs_review to positive_review
By the way the modifications you did to the exception of OA/TD will probably cost a LOT of conflicts.
Just mentionning it because you said that you cared.
Nathann
comment:13 Changed 6 years ago by
Oh, my mistake. Those modifications cannot hurt more than the patch did before you wrote this commit. Sorry for that.
I hope I had conflicts in mind when I first wrote it. Otherwise I will pay it.
Nathann
comment:14 follow-up: ↓ 15 Changed 6 years ago by
The terminology is not understandable:
- MOLS(n,k) but TD(k,n)
- (v,k,lambda)-BIBD but TD(v,k,lambda)
good luck for your future merges... (now you are used to it ;-P)
Vincent
comment:15 in reply to: ↑ 14 Changed 6 years ago by
Yo !
The terminology is not understandable:
I just sent you "Combinatorial Designs: Construction and Analysis" from Douglas Stinson which uses (v,k,lambda)-BIBD
, TD(k,n)
and OA(k,n)
. I believed that the Handbook of Combinatorial Designs did the same but they actually write BIBD(v,k,lambda)
. Their purpose was probably to unify notations, given that (v,k,lambda)-BIBD
is a pretty common :
http://www.maths.qmul.ac.uk/~leonard/repeated11.pdf http://www.argilo.net/files/bibd.pdf
You will also find other occurrences of this naming in the references of the Handbook.
Othey guys say 2-(v,k,lambda) design.
- MOLS(n,k) but TD(k,n)
- (v,k,lambda)-BIBD but TD(v,k,lambda)
Two remarks :
MOLS(n,k)
does not appear in Sage's code- It is true that the constructor of MOLS takes first a n then an k as input. It is true that it can lead to mistakes, and perhaps we should change it.
- If you insist on using BIBD(v,k,lambda) it can be done but it has to be a global change as some pages, eg http://sagemath.org/doc/reference/combinat/sage/combinat/designs/bibd.html already use this terminology. Same for PBD.
good luck for your future merges... (now you are used to it ;-P)
Nathann
comment:16 Changed 6 years ago by
- Branch changed from u/ncohen/16388 to 79178b62b55c9d38b4ee015118e1cbc6acefb8f8
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #16388: Specify the values of k,n in the exceptions