Opened 7 years ago

Closed 7 years ago

#16387 closed enhancement (fixed)

FiniteStateMachine.determinisation: allow input words of length > 1

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.3
Component: finite state machines Keywords: finite_state_machine
Cc: dkrenn, skropf Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 810e8a2 (Commits) Commit: 810e8a21700f612e2043dff85c2e725a6f06854a
Dependencies: Stopgaps:

Description

Previously, all input words had to be of length 1 when determinisation was called. This was a rather superfluous constraint as it is simply required to call split_transitions.

This is now fixed and complemented by some code and documentation cleanup.

Change History (4)

comment:1 Changed 7 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/determinisation-for-long-input-words

comment:2 Changed 7 years ago by cheuberg

  • Commit set to 810e8a21700f612e2043dff85c2e725a6f06854a
  • Status changed from new to needs_review

New commits:

166e76aAutomaton.determinisation: allow input words of length > 1
0acecadSimplified iterator expressions, removed restriction from docstring
0e5c278Merge tag '6.2' into fsm/determinisation-for-long-input-words
6496fbasimplified and corrected doctest
3e9e544corrected spacings; extended one doctest
810e8a2trac #16387: expand doctest to also include initial and final states

comment:3 Changed 7 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Patch looks fine; doctests pass; docs build.

comment:4 Changed 7 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/determinisation-for-long-input-words to 810e8a21700f612e2043dff85c2e725a6f06854a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.