Opened 8 years ago

Closed 8 years ago

#16368 closed defect (fixed)

Missing pkgconf dependencies

Reported by: stephen Owned by:
Priority: blocker Milestone: sage-6.3
Component: build Keywords: pkg-config pkgconfig
Cc: Merged in:
Authors: Volker Braun Reviewers: Martin Albrecht
Report Upstream: N/A Work issues:
Branch: b65b959 (Commits, GitHub, GitLab) Commit: b65b9590227626ad4392ba988fd514c113085d7b
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

We should build the pkgconf package before anything that uses pkg-config.

Change History (14)

comment:1 Changed 8 years ago by leif

We should IMHO repurpose this ticket to either make many if not almost all packages depend on pkgconf (which currently also creates the pkg-config wrapper script in $SAGE_LOCAL/bin/), or to reenable setting PKG_CONFIG_PATH in sage-env.

comment:2 Changed 8 years ago by leif

  • Component changed from porting: BSD to build
  • Description modified (diff)
  • Keywords pkg-config pkgconfig added
  • Priority changed from major to critical

comment:3 Changed 8 years ago by vbraun

Enabling PKG_CONFIG_PATH would still break on OSX, we need to get the dependencies right.

comment:4 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/pkgconf_deps

comment:5 Changed 8 years ago by vbraun

  • Commit set to b65b9590227626ad4392ba988fd514c113085d7b

I've grepped the logs for "pkg-config" and added the relevant dependencies.

Also, whitespace fix. In fact I'm surprised that spaces before the tab in make rules are not a hard error.


New commits:

b65b959add dependencies on pkgconf

comment:6 Changed 8 years ago by vbraun

  • Status changed from new to needs_review

Full rebuild worked and now all log entries point to our pkg-config.

comment:7 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)
  • Summary changed from Build of libm4ri autodetects system libpng instead of sage libpng to Missing pkgconf dependencies

comment:8 Changed 8 years ago by vbraun

  • Priority changed from critical to blocker

comment:9 Changed 8 years ago by malb

  • Status changed from needs_review to positive_review

Looks okay to me.

comment:10 Changed 8 years ago by vbraun

  • Reviewers set to Martin Albrecht

comment:11 Changed 8 years ago by jhpalmieri

Should ncurses install .pc files in SAGE_LOCAL/lib/pkgconfig? If that's a good idea, I can create a followup ticket to do that.

comment:12 Changed 8 years ago by vbraun

Yes, please do!

comment:13 Changed 8 years ago by jhpalmieri

See #16392.

comment:14 Changed 8 years ago by vbraun

  • Branch changed from u/vbraun/pkgconf_deps to b65b9590227626ad4392ba988fd514c113085d7b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.