Opened 7 years ago
Closed 7 years ago
#16359 closed enhancement (fixed)
Implement "first_lexicographic" option for irreducible polynomials over finite fields of odd characteristic
Reported by: | jpflori | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.3 |
Component: | finite rings | Keywords: | finite fields magma irreducible |
Cc: | defeo, pbruin | Merged in: | |
Authors: | Jean-Pierre Flori | Reviewers: | Peter Bruin |
Report Upstream: | N/A | Work issues: | |
Branch: | 2f34e15 (Commits) | Commit: | 2f34e15503868ec2d73482e71ea419c1a4c0bb1f |
Dependencies: | Stopgaps: |
Description
This is the default behavior in Magma.
Change History (8)
comment:1 Changed 7 years ago by
- Branch set to u/jpflori/ticket/16359
- Cc defeo pbruin added
- Commit set to 2f5b9e47af7b98002202f28e1312046d7d48d247
- Keywords finite fields magma irreducible added
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Commit changed from 2f5b9e47af7b98002202f28e1312046d7d48d247 to 44d67e1d0430f91cb2074815d714988f8351d469
Branch pushed to git repo; I updated commit sha1. New commits:
44d67e1 | Leftover degree restriction.
|
comment:3 Changed 7 years ago by
Looks good. One question: do you really want to say "try random polynomials in lexicographic order" in the docstring?!
comment:4 Changed 7 years ago by
Nope. Correcting that now.
comment:5 Changed 7 years ago by
- Commit changed from 44d67e1d0430f91cb2074815d714988f8351d469 to 2f34e15503868ec2d73482e71ea419c1a4c0bb1f
Branch pushed to git repo; I updated commit sha1. New commits:
2f34e15 | Fix typo in finite field poly code.
|
comment:6 Changed 7 years ago by
Done. Now we should make it so this is as fast as Magma's implementation. I think refactoring the finite field poly factorization code and make it use NTL/PARI/FLINT code should be enough.
comment:7 Changed 7 years ago by
- Reviewers set to Peter Bruin
- Status changed from needs_review to positive_review
comment:8 Changed 7 years ago by
- Branch changed from u/jpflori/ticket/16359 to 2f34e15503868ec2d73482e71ea419c1a4c0bb1f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Maybe the non-prime case needs some thought.
New commits:
Implement "first_lexicographic" option for irreducible polys over ffs.