Opened 7 years ago

Closed 7 years ago

#16357 closed defect (fixed)

FiniteStateMachine.default_format_transition_label: accept iterable

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.3
Component: combinatorics Keywords: finite_state_machine
Cc: dkrenn, skropf Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: f941bbd (Commits) Commit: f941bbd0598c3c57a39b732462776392c5fb01c4
Dependencies: Stopgaps:

Description

Current inconsistent behaviour:

sage: T = Transducer()
sage: T.default_format_transition_label([])
'\\varepsilon'
sage: T.default_format_transition_label(iter([]))
''
sage: T.format_transition_label_reversed([])
''

Change code such that \varepsilon is returned in all three instances.

Change History (6)

comment:1 Changed 7 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/format_transition_iterable

comment:2 Changed 7 years ago by cheuberg

  • Commit set to f941bbd0598c3c57a39b732462776392c5fb01c4
  • Status changed from new to needs_review

New commits:

f941bbdtrac #16357: FiniteStateMachine.default_format_transition_label: accept iterable

comment:3 Changed 7 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Patch looks fine.

comment:4 Changed 7 years ago by vbraun

Conflicts, please merge in the next beta.

comment:5 Changed 7 years ago by vbraun

Ignore, wrong ticket..

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/format_transition_iterable to f941bbd0598c3c57a39b732462776392c5fb01c4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.