Opened 7 years ago

Last modified 4 years ago

#16342 needs_work defect

DirichletGroup broken over rings with unhashable coefficients

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-6.4
Component: modular forms Keywords: days71
Cc: Merged in:
Authors: Julian Rüth Reviewers: Aly Deines
Report Upstream: N/A Work issues: probably does not work anymore
Branch: u/saraedum/ticket/16342 (Commits, GitHub, GitLab) Commit: b3f50f1d949fa86e10b856e371a45e7a634331fc
Dependencies: #16317, #15692 Stopgaps:

Status badges

Description

The following fails

sage: K.<a> = Qq(9)
sage: DirichletGroup(1,zeta=K(-1),base_ring=K,zeta_order=2)
TypeError

Change History (19)

comment:1 Changed 7 years ago by saraedum

  • Branch set to u/saraedum/ticket/16342
  • Created changed from 05/12/14 23:34:08 to 05/12/14 23:34:08
  • Modified changed from 05/12/14 23:34:08 to 05/12/14 23:34:08

comment:2 Changed 7 years ago by saraedum

  • Dependencies set to #16317

comment:3 Changed 7 years ago by saraedum

  • Authors set to Julian Rueth
  • Modified changed from 05/13/14 00:00:26 to 05/13/14 00:00:26
  • Status changed from new to needs_review

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 6 years ago by jdemeyer

  • Commit set to 8b7a3f64dc447cc1fe5b65b52d6e60eeae337548

What's the relation between #16342 and #16258? In any case, needs rebasing.

comment:6 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:7 Changed 6 years ago by git

  • Commit changed from 8b7a3f64dc447cc1fe5b65b52d6e60eeae337548 to 677a9271e765b67702a2859d6345eaeb9ed65948

Branch pushed to git repo; I updated commit sha1. New commits:

69c1cdcMerge branch 'develop' into t/16342/ticket/16342
677a927Made output of DirichletGroup test case stable

comment:8 Changed 6 years ago by saraedum

  • Status changed from needs_work to needs_review

comment:9 Changed 6 years ago by pbruin

Note: this also appears to be fixed by #6018.

comment:10 Changed 6 years ago by pbruin

  • Status changed from needs_review to needs_work

There are doctest failures, see the patchbot report.

comment:11 Changed 6 years ago by saraedum

  • Dependencies changed from #16317 to #16317, #15692

The cache can currently not be pickled if it contains p-adics. #15692 sort of fixes this, but once this gets merged, I need to change the __setstate__ in here to restore the cache.

comment:12 Changed 5 years ago by git

  • Commit changed from 677a9271e765b67702a2859d6345eaeb9ed65948 to f0d91d4a0519d080b414b35de2f5462a63fb82fa

Branch pushed to git repo; I updated commit sha1. New commits:

f0d91d4Merge branch 'develop' into t/16342/ticket/16342

comment:13 Changed 5 years ago by saraedum

  • Status changed from needs_work to needs_review

comment:14 Changed 5 years ago by aly.deines

  • Reviewers set to Aly Deines
  • Status changed from needs_review to positive_review

Looks good.

comment:15 Changed 5 years ago by jen

  • Keywords days71 added

comment:16 Changed 5 years ago by pbruin

  • Status changed from positive_review to needs_work

Merge conflict with #6018.

comment:17 Changed 4 years ago by git

  • Commit changed from f0d91d4a0519d080b414b35de2f5462a63fb82fa to b3f50f1d949fa86e10b856e371a45e7a634331fc

Branch pushed to git repo; I updated commit sha1. New commits:

b3f50f1Merge remote-tracking branch 'origin/develop' into t/16342/ticket/16342

comment:18 Changed 4 years ago by saraedum

  • Work issues set to probably does not work anymore

New commits:

b3f50f1Merge remote-tracking branch 'origin/develop' into t/16342/ticket/16342

comment:19 Changed 4 years ago by saraedum

  • Authors changed from Julian Rueth to Julian Rüth
Note: See TracTickets for help on using tickets.