Opened 7 years ago

Closed 7 years ago

#16322 closed defect (fixed)

Magma doctest failures

Reported by: malb Owned by:
Priority: minor Milestone: sage-6.3
Component: PLEASE CHANGE Keywords: magma
Cc: leif Merged in:
Authors: Martin Albrecht Reviewers: Volker Braun
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: 1b5d36d (Commits) Commit: 1b5d36de0d5dac98537311e8c95dcb62d8bf2d80
Dependencies: #16282 Stopgaps:

Description

These doctests currently fail:

sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/symbolic/expression.pyx
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/number_field/number_field.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/matrix/benchmark.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/polynomial/polynomial_rational_flint.pyx
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/polynomial/multi_polynomial_sequence.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/integer_ring.pyx 

Change History (12)

comment:1 Changed 7 years ago by malb

  • Status changed from new to needs_info

comment:2 Changed 7 years ago by malb

  • Branch set to u/malb/16322-magma-doctests
  • Commit set to 46246faecc4d27cfe9b54ac62e9ef36f15ec06fa

All doctest failures fixed except for

sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/number_field/number_field.py

where I'm not immediately sure what to do.


New commits:

548d2e6fix magma(P) for P a multivariate polynomial ring
566082bfix various Magma doctest failures
1938841Merge branch 'develop' of trac.sagemath.org:sage into magma
46246fafix magma doctest failures

comment:3 Changed 7 years ago by malb

  • Dependencies set to 16282

comment:4 Changed 7 years ago by malb

  • Dependencies changed from 16282 to #16282

comment:5 follow-up: Changed 7 years ago by leif

These were the ones failing for me on bsd.math with vanilla Sage 6.2 (and --long --optional=magma,sage --all, Magma V2.18-6):

----------------------------------------------------------------------
sage -t --long src/sage/interfaces/magma.py  # 21 doctests failed
sage -t --long src/sage/matrix/benchmark.py  # 26 doctests failed
sage -t --long src/sage/matrix/matrix1.pyx  # 2 doctests failed
sage -t --long src/sage/rings/integer_ring.pyx  # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring.py  # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring_element.py  # 2 doctests failed
sage -t --long src/sage/rings/number_field/number_field.py  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/multi_polynomial.pyx  # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ideal.py  # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ring_generic.pyx  # 5 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_sequence.py  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/pbori.pyx  # 3 doctests failed
sage -t --long src/sage/rings/polynomial/polynomial_element.pyx  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/polynomial_rational_flint.pyx  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/term_order.py  # 1 doctest failed
sage -t --long src/sage/symbolic/expression.pyx  # 1 doctest failed
sage -t --long src/doc/en/bordeaux_2008/birds_other.rst  # 3 doctests failed
----------------------------------------------------------------------

comment:6 Changed 7 years ago by leif

P.S.: Sorry, I only later noticed the purpose of #16282 was not to fix all Magma doctests; I somehow completely misread the ticket and/or your post to sage-devel (presumably due to the Gmane outage ;-) )...

comment:7 in reply to: ↑ 5 Changed 7 years ago by leif

Replying to leif:

These were the ones failing for me on bsd.math with vanilla Sage 6.2 (and --long --optional=magma,sage --all, Magma V2.18-6)

Full log here.

comment:8 Changed 7 years ago by git

  • Commit changed from 46246faecc4d27cfe9b54ac62e9ef36f15ec06fa to 1b5d36de0d5dac98537311e8c95dcb62d8bf2d80

Branch pushed to git repo; I updated commit sha1. New commits:

1b5d36dmagma error reporting changed

comment:9 Changed 7 years ago by malb

these are all resolved except for the Galois group thing mentioned above (I fixed one more issue where newer versions of Magma report errors slightly different from older versions)

comment:10 Changed 7 years ago by malb

anyone up for reviewing tis?

comment:11 Changed 7 years ago by vbraun

  • Reviewers set to Volker Braun

Maybe you want to set the ticket to "needs review" first? Is it?

comment:12 Changed 7 years ago by vbraun

  • Branch changed from u/malb/16322-magma-doctests to 1b5d36de0d5dac98537311e8c95dcb62d8bf2d80
  • Resolution set to fixed
  • Status changed from needs_info to closed
Note: See TracTickets for help on using tickets.