Opened 2 years ago
Closed 2 years ago
#16317 closed enhancement (fixed)
UniqueFactory for unhashable elements
Reported by: | saraedum | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.3 |
Component: | misc | Keywords: | |
Cc: | Merged in: | ||
Authors: | Julian Rueth | Reviewers: | Peter Bruin |
Report Upstream: | N/A | Work issues: | |
Branch: | ba9befa (Commits) | Commit: | ba9befadb9ee1e26966c9eee9edbdfe86c85fd14 |
Dependencies: | #16316 | Stopgaps: |
Description
Similar to #16316, caching does not work in factories if some of the parameters
are not hashable.
With this ticket, factories look at the _cache_key
defined for cached
functions/methods if a parameter is not hashable.
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to u/saraedum/ticket/16317
- Created changed from 05/09/14 23:09:02 to 05/09/14 23:09:02
- Modified changed from 05/09/14 23:09:02 to 05/09/14 23:09:02
comment:2 Changed 2 years ago by
- Dependencies set to #16316
comment:3 Changed 2 years ago by
- Modified changed from 05/09/14 23:16:48 to 05/09/14 23:16:48
- Status changed from new to needs_review
comment:4 Changed 2 years ago by
- Commit set to ba9befadb9ee1e26966c9eee9edbdfe86c85fd14
comment:5 Changed 2 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:6 Changed 2 years ago by
- Reviewers set to Peter Bruin
- Status changed from needs_review to positive_review
comment:7 Changed 2 years ago by
- Branch changed from u/saraedum/ticket/16317 to ba9befadb9ee1e26966c9eee9edbdfe86c85fd14
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Introduced _cache_key for sage objects
made polynomials with unhashable coefficients unhashable
Merge branch 'u/saraedum/ticket/16251' of git://trac.sagemath.org/sage into ticket/16316
Implemented _cache_key() for polynomials
Enable caching for non-hashable objects
Enabled caching for unhashable objects in factories