Opened 8 years ago
Closed 8 years ago
#16307 closed defect (fixed)
Fix small bug in G.strong_orientation()
| Reported by: | Jennet Dickinson | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-6.3 |
| Component: | graph theory | Keywords: | |
| Cc: | Robert Lipshitz | Merged in: | |
| Authors: | Jennet Dickinson | Reviewers: | Nathann Cohen |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 17a1a97 (Commits, GitHub, GitLab) | Commit: | 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Fix small bug in G.strong_orientation() by replacing
d.has_edge(e[0].e[1])
with
d.has_edge(e[0],e[1])
The bug causes G.strong_orientation() to fail for G a multigraph. Also added a small multigraph to the doctests for G.strong_orientation()
Change History (8)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 8 years ago by
| Branch: | → u/jdickinson/ticket/16307 |
|---|---|
| Created: | May 8, 2014, 12:50:47 AM → May 8, 2014, 12:50:47 AM |
| Modified: | May 8, 2014, 2:02:21 PM → May 8, 2014, 2:02:21 PM |
comment:4 Changed 8 years ago by
| Commit: | → 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96 |
|---|---|
| Description: | modified (diff) |
New commits:
| 17a1a97 | Fixed bug preventing G.strong_orientation() from working on G a multigraph, added a small multigraph to doctests
|
comment:5 Changed 8 years ago by
| Status: | new → needs_review |
|---|
comment:6 Changed 8 years ago by
| Reviewers: | → Nathann Cohen |
|---|---|
| Status: | needs_review → positive_review |
Ahem.... Dead right :-P
Thanks for fixing this !
comment:7 Changed 8 years ago by
| Milestone: | sage-6.2 → sage-6.3 |
|---|
comment:8 Changed 8 years ago by
| Branch: | u/jdickinson/ticket/16307 → 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
(curious)