Opened 5 years ago

Closed 5 years ago

#16307 closed defect (fixed)

Fix small bug in G.strong_orientation()

Reported by: jdickinson Owned by:
Priority: minor Milestone: sage-6.3
Component: graph theory Keywords:
Cc: lipshitz Merged in:
Authors: Jennet Dickinson Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 17a1a97 (Commits) Commit: 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96
Dependencies: Stopgaps:

Description (last modified by jdickinson)

Fix small bug in G.strong_orientation() by replacing d.has_edge(e[0].e[1]) with d.has_edge(e[0],e[1])

The bug causes G.strong_orientation() to fail for G a multigraph. Also added a small multigraph to the doctests for G.strong_orientation()

Change History (8)

comment:1 Changed 5 years ago by ncohen

(curious)

comment:2 Changed 5 years ago by jdickinson

  • Description modified (diff)

comment:3 Changed 5 years ago by jdickinson

  • Branch set to u/jdickinson/ticket/16307
  • Created changed from 05/08/14 00:50:47 to 05/08/14 00:50:47
  • Modified changed from 05/08/14 14:02:21 to 05/08/14 14:02:21

comment:4 Changed 5 years ago by jdickinson

  • Commit set to 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96
  • Description modified (diff)

New commits:

​17a1a97Fixed bug preventing G.strong_orientation() from working on G a multigraph, added a small multigraph to doctests

comment:5 Changed 5 years ago by jdickinson

  • Status changed from new to needs_review

comment:6 Changed 5 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Ahem.... Dead right :-P

Thanks for fixing this !

comment:7 Changed 5 years ago by leif

  • Milestone changed from sage-6.2 to sage-6.3

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/jdickinson/ticket/16307 to 17a1a97a56b77ec4c0df0ac6ed0c51638f6ede96
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.