Opened 7 years ago
Closed 7 years ago
#16279 closed enhancement (fixed)
BIBD from Transversal Designs
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.3 
Component:  combinatorics  Keywords:  design, bibd 
Cc:  vdelecroix, brett, dimpase, knsam  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Kannappan Sampath 
Report Upstream:  N/A  Work issues:  
Branch:  4115b72 (Commits)  Commit:  4115b7285b56268418304681ed36d08e58cfd3fe 
Dependencies:  #16272, #16091  Stopgaps: 
Description
This branch implements three constructions of BIBD from transversal designs. Short, efficient, AND useful for the general construction of BIBD with k=5.
As found in http://www.argilo.net/files/bibd.pdf
The constructions are explained in the documentation, too.
Change History (17)
comment:1 Changed 7 years ago by
 Branch set to u/ncohen/16279
 Status changed from new to needs_review
comment:2 Changed 7 years ago by
 Commit set to c881070eef242826e8ea0c3b3d60d1c41be61a64
comment:3 Changed 7 years ago by
 Commit changed from c881070eef242826e8ea0c3b3d60d1c41be61a64 to 569c4858a95177d1075c756375c28d676f380586
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
569c485  trac #16279: BIBD from Transversal Designs

comment:4 Changed 7 years ago by
 Commit changed from 569c4858a95177d1075c756375c28d676f380586 to 60e8d35dbd2d0972fab0e306fcecac7e1225dc41
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0812a73  trac #16281: Simplification

61dc86b  16281: long comment for the construction of the projective plane

51daa7f  trac #16281: correct a doctest

e090f92  trac #16272: merge #16281

9a221be  trac #16272: fix doctests

5074eee  trac #16272: finer doctest to test the output of transversal_design

d81f265  trac #16272: ultimate doctest

47798d2  trac #16272: simplifying the structure of orthogonal_array

d34b012  trac #16272: Merged with updated #16227

60e8d35  trac #16279: Merged with updated #16272

comment:7 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:8 Changed 7 years ago by
Hi Nathann,
I would like to review this patch and I have the following remarks about your patch:
 The doc does not build and I have no idea how to fix these errors!
 Linguistic: A BIBD is a pair (X, B) where X is the set of points and B is the set of blocks. But, the description of the new BIBD as well as how the given BIBD is used in the construction does not make things clear: you say replace sth by a BIBD: what does this mean?
In view of these remarks, I am setting this to needs_work
;).
[If not for the fact that does not build, I would have went ahead and made the other changes...]
 Kannappan.
comment:9 Changed 7 years ago by
 Status changed from needs_review to needs_work
comment:10 Changed 7 years ago by
That was because `(v,k,1)`BIBD
is okay for Sphinx, but `(v,k,1)`BIBD
is not. Which he clearly reported by saying "Something is wrong". I hate this thing.
Anyway, fixed.
I also avoided the word "replaced" using the same phrasing as in the two other constructions. I also replaced two occurrences of BIBD by BIBDs to make it clearer that we were talking of several BIBD.
I also merged #16091 in, as it is a dependency of this patch.
Nathann
comment:11 Changed 7 years ago by
 Status changed from needs_work to needs_review
comment:12 Changed 7 years ago by
 Commit changed from 60e8d35dbd2d0972fab0e306fcecac7e1225dc41 to e941a54dc3e757b359a54a9fd8f0f49358fad020
comment:13 Changed 7 years ago by
Hi!
 My doc building stops at:
[tensor ] build succeeded.
I have seen that there is a discussion on sagedevel. So, I will see what I can do to fix it. I will have this patch reviewed by evening tommorrow (for me!). Sorry for the delay, Nathann.
 Kannappan.
New commits:
927d325  trac #16279: Merged with 6.2

e1b29bf  trac #16279: Fixing the doc

e722cb1  trac #16091: A missing obvious case for BIBD

e941a54  trac #16279: Merged with updated #16091

comment:14 Changed 7 years ago by
 Commit changed from e941a54dc3e757b359a54a9fd8f0f49358fad020 to 4115b7285b56268418304681ed36d08e58cfd3fe
comment:15 followup: ↓ 16 Changed 7 years ago by
 Reviewers set to Kannappan Sampath
Hi Nathann,
I just have one query: given that the method is called BIBD_From_TD, I was expecting the function to return a block design, but it returns a list instead. I also noted that this method is used in the BalancedIncompleteBlockDesign
to construct a block design when existence = True
. So, this is probably the desiderata, but I thought that this is worth pointing out...
You may set this to positive review
if you would like to return a list instead of a BlockDesign
...
This ticket reviewed using SMC!! :)
Kannappan.
comment:16 in reply to: ↑ 15 Changed 7 years ago by
 Status changed from needs_review to positive_review
Helloooooooo !!!
I just have one query: given that the method is called BIBD_From_TD, I was expecting the function to return a block design, but it returns a list instead.
Hmmmm... Well, admittedly I do not like to wrap a list in a class if I don't need to (because doing so may cost nontrivial computations), but in this case the function is really only made to be called by the "main" method, i.e. the constructor of BIBD. It can be called recursively, and it would be nice if we don't convert all the stuff into a Block Design during those calls as we have no reason to ^^;
You may set this to
positive review
if you would like to return a list instead of aBlockDesign
...
Thank you very much ! Now we are only one ticket away from having ALL bibd with k=5, and I have another code ready on my computer : Wilson's construction of MOLS with two truncated groups, which should make a big difference in our table of MOLS. But that's for a bit later, for many patches are still waiting to be merged and this is already sufficiently complicated as it is. Pretty soon, I hope !!!
Nathann
comment:17 Changed 7 years ago by
 Branch changed from u/ncohen/16279 to 4115b7285b56268418304681ed36d08e58cfd3fe
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
trac #16227: Product construction of Transversal Designs
trac #16227: Merged with updated #15310
corrected doctests + new doctests
trac #16227: Replace exception with booleans in the doctests
trac #16231: Equivalence between OA/TD/MOLS
trac #16231: Merged with updated #16227
more documentation to orthogonal_arrays.py
remove MOLS construction for prime powers + doc
trac #16272: Replacing availability by existence and forwarding the results between design constructors
trac #16279: BIBD from Transversal Designs