Opened 7 years ago

Closed 7 years ago

#16267 closed enhancement (fixed)

option to change column alignment in a matrix (in LaTeX output)

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.3
Component: misc Keywords: LaTeX, matrix
Cc: robertwb Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: ea6c3af (Commits, GitHub, GitLab) Commit: ea6c3af0056a86a54630c801089af6c376ee32de
Dependencies: Stopgaps:

Status badges

Description

At the moment all columns are aligned on the right. This should be more flexible and allowing center and left as well.

Change History (8)

comment:1 Changed 7 years ago by dkrenn

Patch written and follows soon...

comment:2 Changed 7 years ago by dkrenn

  • Branch set to u/dkrenn/misc/latex/matrix_column_alignment

comment:3 Changed 7 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to ea6c3af0056a86a54630c801089af6c376ee32de
  • Status changed from new to needs_review

Patch uploaded, please review.


New commits:

ea6c3afadd a option to align columns in a matrix other that "right"

comment:4 Changed 7 years ago by cheuberg

  • Reviewers set to Clemens Heuberger

I have reviewed this patch, doctests pass, documentation builds. This is a positive review from my side, however, I keep the status as needs_review for the time being as this is not really my area in sage.

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 7 years ago by cheuberg

  • Cc robertwb added

I add Robert Bradshaw to Cc as he was the last to change the most affected line (2f182b).

If there are no further comments, I'll set this to positive_review in a week.

comment:7 Changed 7 years ago by cheuberg

  • Status changed from needs_review to positive_review

As there do not seem to be any other comments, I set this to positive_review.

comment:8 Changed 7 years ago by vbraun

  • Branch changed from u/dkrenn/misc/latex/matrix_column_alignment to ea6c3af0056a86a54630c801089af6c376ee32de
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.