Opened 8 years ago

Closed 8 years ago

#16266 closed enhancement (fixed)

FiniteStateMachine: option to show empty final word out labels

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorics Keywords: finite_state_machine, latex
Cc: cheuberg, skropf Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 0179f71 (Commits, GitHub, GitLab) Commit: 0179f71e5727c4a6c2a6a8d221616f4c958cdd45
Dependencies: #16207, #16253, #16229 Stopgaps:

Status badges

Description

This implements a flag to show (in the latex representation) the label when the final word out is empty.

Change History (14)

comment:1 Changed 8 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/accepting_show_empty_final_word_out

comment:2 Changed 8 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Branch u/dkrenn/fsm/accepting_show_empty_final_word_out deleted
  • Cc cheuberg skropf added
  • Dependencies set to #16207, #16253
  • Status changed from new to needs_review

Patch uploaded

comment:3 Changed 8 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/accepting_show_empty_final_word_out
  • Commit set to eed6553dce6cb612b27f6d128e38631ce5086237

Last 10 new commits:

c15e3d8Small changes in the documentation of with_final_word_out
0312268line break in docstring
e0963c4FiniteStateMachine.with_final_word_out: replace "loop" by "cycle"
2c11f6aFiniteStateMachine.with_final_word_out: only support transitions with input labels of length 1
731d89cMerge branch 'fsm/with_final_word_out' into fsm/paper
d05cb3aAdded transducers.weight to generators
e8dfaa0Merge branch 'fsm/weight_transducers' into fsm/paper
f7cb396Correction of transducers.weight
09a963bMerge branch 'fsm/weight_transducers' into fsm/paper
eed6553implemented accepting_show_empty

comment:4 Changed 8 years ago by cheuberg

  • Branch changed from u/dkrenn/fsm/accepting_show_empty_final_word_out to u/cheuberg/fsm/accepting_show_empty_final_word_out_1
  • Commit changed from eed6553dce6cb612b27f6d128e38631ce5086237 to 27c13be6f03ccc4422a3123a74a9d65b76b70850
  • Reviewers set to Clemens Heuberger

Reviewed, code is ok, doctests pass. It seems that the branch contains some non-pertinent tickets, so I cherry-picked your commit on a new branch, based only on #16253.

Please cross-review.


Last 10 new commits:

1f14955FiniteStateMachine._latex_: use tikz arrow style "latex"
56b1d48default accepting_distance=7ex because of $ in final output
a0d894eMerge remote-tracking branch 'aau/fsm/asymptotic-moments' into fsm/latex-options-digits
8f4cd21Merge remote-tracking branch 'aau/fsm/latex-options-digits' into fsm/final_output_construction
d5d08ccDeleted a check for consistency in _latex_
0469d11reworded ValueError (joined sentences)
df6f9fbreviewer patch: line breaks in documentation
bbe0866reworded two docstrings
21392c5added doctests to FSMState.deepcopy to check that deepcopy of a property works
27c13beimplemented accepting_show_empty

comment:5 Changed 8 years ago by cheuberg

  • Keywords finite_state_machine added; finite state machine removed

comment:6 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/accepting_show_empty_final_word_out_1 to u/dkrenn/fsm/accepting_show_empty_final_word_out_1

comment:7 Changed 8 years ago by dkrenn

  • Commit changed from 27c13be6f03ccc4422a3123a74a9d65b76b70850 to 455809e76568b3255e18ef1f80fb03a8b8a45b1d

Cross-reviewed: Ok.

Added a doctest; introduced EndOfWordSymbol?, so that this can be changed by user. Please review.


New commits:

455809edoctest added for accepting_show_empty; EndOfWordLaTeX-symbol can now be changed by user

comment:8 Changed 8 years ago by cheuberg

  • Status changed from needs_review to positive_review

reviewed modified patch, doctests pass, documentation is fine.

comment:9 Changed 8 years ago by cheuberg

  • Status changed from positive_review to needs_work

new doctest fails after merging with #16229.

Last edited 8 years ago by cheuberg (previous) (diff)

comment:10 Changed 8 years ago by git

  • Commit changed from 455809e76568b3255e18ef1f80fb03a8b8a45b1d to 0179f71e5727c4a6c2a6a8d221616f4c958cdd45

Branch pushed to git repo; I updated commit sha1. New commits:

218372eFiniteStateMachine._latex_ and latex_options: customize loop position
8ba3e50corrected one PEP8-spacing
8971334Merge branch 't/16229/fsm/latex-loop' into t/16266/fsm/accepting_show_empty_final_word_out_1
0179f71adapted one doctest after merge of #16229

comment:11 Changed 8 years ago by dkrenn

  • Dependencies changed from #16207, #16253 to #16207, #16253, #16229
  • Status changed from needs_work to needs_review

Merged #16229 and adapted doctest. Please review.

comment:12 Changed 8 years ago by cheuberg

  • Status changed from needs_review to positive_review

thanks, doctests pass now.

comment:13 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:14 Changed 8 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/accepting_show_empty_final_word_out_1 to 0179f71e5727c4a6c2a6a8d221616f4c958cdd45
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.