Opened 8 years ago
Closed 8 years ago
#16266 closed enhancement (fixed)
FiniteStateMachine: option to show empty final word out labels
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage6.3 
Component:  combinatorics  Keywords:  finite_state_machine, latex 
Cc:  cheuberg, skropf  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  0179f71 (Commits, GitHub, GitLab)  Commit:  0179f71e5727c4a6c2a6a8d221616f4c958cdd45 
Dependencies:  #16207, #16253, #16229  Stopgaps: 
Description
This implements a flag to show (in the latex representation) the label when the final word out is empty.
Change History (14)
comment:1 Changed 8 years ago by
 Branch set to u/dkrenn/fsm/accepting_show_empty_final_word_out
comment:2 Changed 8 years ago by
 Branch u/dkrenn/fsm/accepting_show_empty_final_word_out deleted
 Cc cheuberg skropf added
 Dependencies set to #16207, #16253
 Status changed from new to needs_review
comment:3 Changed 8 years ago by
 Branch set to u/dkrenn/fsm/accepting_show_empty_final_word_out
 Commit set to eed6553dce6cb612b27f6d128e38631ce5086237
Last 10 new commits:
c15e3d8  Small changes in the documentation of with_final_word_out

0312268  line break in docstring

e0963c4  FiniteStateMachine.with_final_word_out: replace "loop" by "cycle"

2c11f6a  FiniteStateMachine.with_final_word_out: only support transitions with input labels of length 1

731d89c  Merge branch 'fsm/with_final_word_out' into fsm/paper

d05cb3a  Added transducers.weight to generators

e8dfaa0  Merge branch 'fsm/weight_transducers' into fsm/paper

f7cb396  Correction of transducers.weight

09a963b  Merge branch 'fsm/weight_transducers' into fsm/paper

eed6553  implemented accepting_show_empty

comment:4 Changed 8 years ago by
 Branch changed from u/dkrenn/fsm/accepting_show_empty_final_word_out to u/cheuberg/fsm/accepting_show_empty_final_word_out_1
 Commit changed from eed6553dce6cb612b27f6d128e38631ce5086237 to 27c13be6f03ccc4422a3123a74a9d65b76b70850
 Reviewers set to Clemens Heuberger
Reviewed, code is ok, doctests pass. It seems that the branch contains some nonpertinent tickets, so I cherrypicked your commit on a new branch, based only on #16253.
Please crossreview.
Last 10 new commits:
1f14955  FiniteStateMachine._latex_: use tikz arrow style "latex"

56b1d48  default accepting_distance=7ex because of $ in final output

a0d894e  Merge remotetracking branch 'aau/fsm/asymptoticmoments' into fsm/latexoptionsdigits

8f4cd21  Merge remotetracking branch 'aau/fsm/latexoptionsdigits' into fsm/final_output_construction

d5d08cc  Deleted a check for consistency in _latex_

0469d11  reworded ValueError (joined sentences)

df6f9fb  reviewer patch: line breaks in documentation

bbe0866  reworded two docstrings

21392c5  added doctests to FSMState.deepcopy to check that deepcopy of a property works

27c13be  implemented accepting_show_empty

comment:5 Changed 8 years ago by
 Keywords finite_state_machine added; finite state machine removed
comment:6 Changed 8 years ago by
 Branch changed from u/cheuberg/fsm/accepting_show_empty_final_word_out_1 to u/dkrenn/fsm/accepting_show_empty_final_word_out_1
comment:7 Changed 8 years ago by
 Commit changed from 27c13be6f03ccc4422a3123a74a9d65b76b70850 to 455809e76568b3255e18ef1f80fb03a8b8a45b1d
Crossreviewed: Ok.
Added a doctest; introduced EndOfWordSymbol?, so that this can be changed by user. Please review.
New commits:
455809e  doctest added for accepting_show_empty; EndOfWordLaTeXsymbol can now be changed by user

comment:8 Changed 8 years ago by
 Status changed from needs_review to positive_review
reviewed modified patch, doctests pass, documentation is fine.
comment:9 Changed 8 years ago by
 Status changed from positive_review to needs_work
new doctest fails after merging with #16229.
comment:10 Changed 8 years ago by
 Commit changed from 455809e76568b3255e18ef1f80fb03a8b8a45b1d to 0179f71e5727c4a6c2a6a8d221616f4c958cdd45
Branch pushed to git repo; I updated commit sha1. New commits:
218372e  FiniteStateMachine._latex_ and latex_options: customize loop position

8ba3e50  corrected one PEP8spacing

8971334  Merge branch 't/16229/fsm/latexloop' into t/16266/fsm/accepting_show_empty_final_word_out_1

0179f71  adapted one doctest after merge of #16229

comment:11 Changed 8 years ago by
 Dependencies changed from #16207, #16253 to #16207, #16253, #16229
 Status changed from needs_work to needs_review
Merged #16229 and adapted doctest. Please review.
comment:12 Changed 8 years ago by
 Status changed from needs_review to positive_review
thanks, doctests pass now.
comment:13 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:14 Changed 8 years ago by
 Branch changed from u/dkrenn/fsm/accepting_show_empty_final_word_out_1 to 0179f71e5727c4a6c2a6a8d221616f4c958cdd45
 Resolution set to fixed
 Status changed from positive_review to closed
Patch uploaded