Opened 7 years ago

Last modified 6 years ago

#16262 new defect

Tachyon raytracer should throw error if unsuccessful

Reported by: niles Owned by:
Priority: major Milestone: sage-6.4
Component: graphics Keywords: tachyon
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

One can read whether or not tachyon_rt is successful using the verbose option. But it would be better to raise an error if rendering is unsuccessful.

This would make doctests of tachyon plots more meaningful. As it is, a doctest such as the one for Tachyon.show can pass even if the .dat file is invalid and no image is produced.

An obvious fix would be to use the exit status of the tachyon command run from os.system. Unfortunately I seemed to get exit status 0 even when the rendering was not successful.

Change History (2)

comment:1 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:2 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.