Changes between Initial Version and Version 1 of Ticket #16261, comment 29


Ignore:
Timestamp:
Aug 16, 2014, 5:42:08 PM (8 years ago)
Author:
Travis Scrimshaw
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16261, comment 29

    initial v1  
    44
    55As for finding the orders of the original cyclic groups in `short_repr`, I think the current implementation is okay for now. You could make this data into a (cached) method, but IDK if this is worthwhile or useful for anyone. A "better" fix would be to pass this data from the factory function to the class, but you should deal with handling old pickles which don't (a priori) contain this part of the class's input.
     6
     7So in the end, if you're okay with my changes, then positive review.
    68----
    79New commits: