Python 2.7.7

[vbraun]

Tarball: ​http://boxen.math.washington.edu/home/vbraun/upstream/python-2.7.7.tar.gz

[vbraun]

The uuid patch does not apply any more. Removing it for now.

[vbraun]

New commits:

​920ae38

Python 2.7.6

[fbissey]

What was the uuid patch for?

[vbraun]

Some cygwin thing, can't test to see if its still necessary.

[fbissey]

Better ask Jean-Pierre about that patch then.

[jpflori]

See #16119. Without firther investigation, i would say it's still needed (unless the uuid module has been heavily modified in this new release).

[vbraun]

It doesn't apply, so the module has been modified. In any case I have no way of testing it. The ball is on your court.

[jpflori]

Ok, I'll give it a shot asap (which may be not before this week-end).

[jpflori]

So, I already tested it and it seems that ​http://bugs.python.org/issue18784 which makes the previous patch (inspired from ​http://bugs.python.org/issue11063) fail to apply is not enough to prevent the segfaults I encountered in #16119. I'll try to rebase the patch asap.

[jpflori]

Rebased patch

[tscrim]

FYI - There was an inquiry about getting this in at ​https://groups.google.com/forum/#!topic/sage-devel/_zTj2wphoTQ.

[fbissey]

Yes I noticed, my apologies for not coming back to this sooner. Once someone has pushed the patch into the branch I can give it a positive review.

[tscrim]

Done.

---

New commits:

​2f3d42e	Merge branch 'u/vbraun/python_2_7_6' of trac.sagemath.org:sage into public/ticket/python_2_7_6
​76ffacd	Added uuid patch back.

[fbissey]

Hummm.... The heading for uuid patch mention python 2.7.5 not 2.7.6. Have checked that it applies cleanly?

[tscrim]

No, I just merged in Jean-Pierre's patch posted here.

[stephen]

Replying to fbissey:

Hummm.... The heading for uuid patch mention python 2.7.5 not 2.7.6. Have checked that it applies cleanly?

I just checked it. It does apply cleanly to python-2.7.6.

[fbissey]

OK I don't have a setup handy to import the branch and test it myself. It is just a bit curious but I will mark this as positive review.

[vbraun]

Doesn't work on OSX because of case-insensitive file system and our retarded way of mv python-2.7.6 src (directory name is Python-2.7.6)

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​e9aa3c6	ignore case when renaming source directory
​49d145e	Merge branch 't/16415/ignore_case_in_package_directory' into t/16260/public/ticket/python_2_7_6-16260
​d0da33d	rely on the tarball directory being renamed to src

[leif]

Wonder whether that works as expected on Cygwin... (so I feel unable to give it positive review)

J-P?

[leif]

/foo/Sage/sage-6.3.beta2-gcc-4.4.3/build/pipestatus "sage-spkg ${SAGE_SPKG_OPTS} python-2.7.6 2>&1" "tee -a /foo/Sage/sage-6.3.beta2-gcc-4.4.3/logs/pkgs/python-2.7.6.log"
cp /foo/Sage/sage-6.3.beta2-gcc-4.4.3/src/bin/sage-spkg /foo/Sage/sage-6.3.beta2-gcc-4.4.3/local/bin/sage-spkg
Found local metadata for python-2.7.6
Attempting to download package python-2.7.6
>>> Trying to download http://www.sagemath.org/packages/upstream/python/python-2.7.6.tar.bz2
[............................................................]
Checksum: ee6facccd17222966e5e846d8104f3431a4ecdc2 vs ee6facccd17222966e5e846d8104f3431a4ecdc2
python-2.7.6
====================================================
Setting up build directory for python-2.7.6
Finished set up
****************************************************
Host system:
Linux mediocrity 3.0.0-32-generic #51~lucid1-Ubuntu SMP Fri Mar 22 17:34:23 UTC 2013 x86_64 GNU/Linux
****************************************************
C compiler: gcc
C compiler version:
Using built-in specs.
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.4.3-4ubuntu5.1' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --program-suffix=-4.4 --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-plugin --enable-objc-gc --disable-werror --with-arch-32=i486 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5.1)
****************************************************
./spkg-install: line 23: cd: src: No such file or directory
./spkg-install: line 27: ../patches/*.patch: No such file or directory
Error: Patch "../patches/*.patch" failed to apply.

real    0m0.022s
user    0m0.000s
sys     0m0.000s
************************************************************************
Error installing package python-2.7.6

(Second try doesn't work either.)

$ git log src/bin/sage-spkg
commit e9aa3c608f1407fc5ff36236b442e7db42f8f871
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Fri May 30 16:35:56 2014 +0100

    ignore case when renaming source directory

...

FWIW,

$ bash --version
GNU bash, version 4.1.5(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

[vbraun]

Does export LC_ALL=C fix it?

[leif]

Replying to leif:

FWIW,

$ bash --version
GNU bash, version 4.1.5(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Though "suboptimal",

    mv "${PKG_NAME_UPSTREAM%.tar*}"* src

works for me.

[leif]

Replying to vbraun:

Does export LC_ALL=C fix it?

Sorry, missed your question. But no, it doesn't.

[vbraun]

I added the workaround to the dependency ticket.

[jpflori]

Hi all, the rebased patch I posted was definitely needed, on my own Cygwin64 install at least, to let some Python dependencies of the notebook build. Note though that Python is still very broken on Cygwin64. A bunch of its testsuite fail, but I would not assume that the patch worsened anything. Surely some other patches from the Cygwin folk are needed but I have no time to devote to investigating that now. A first step would be if the Cygwin distributed Python also fails part of its testsuite or not.

[leif]

Replying to jpflori:

Hi all, the rebased patch I posted was definitely needed, on my own Cygwin64 install at least, to let some Python dependencies of the notebook build. Note though that Python is still very broken on Cygwin64. A bunch of its testsuite fail, but I would not assume that the patch worsened anything. Surely some other patches from the Cygwin folk are needed but I have no time to devote to investigating that now. A first step would be if the Cygwin distributed Python also fails part of its testsuite or not.

Can you confirm that installation of the new spkg (with #16415) works on Cygwin?

If so, please set both tickets to "positive review" (unless there are other issues I don't know of).

[jpflori]

I'll do that tomorrow. I don't have any computer with internet access where I can plug the hdd containing the vm right now.

[leif]

Replying to jpflori:

I'll do that tomorrow. I don't have any computer with internet access where I can plug the hdd containing the vm right now.

Virtual memory? ;-)

Ok, just noticed the branch has to be rebased on #16415 anyway (it still contains a patch to sage-spkg [which isn't based on #16415 nor the other way around]).

[leif]

ROFL, William just posted

Python 2.7.7 was released already (I think yesterday).

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​9b31585	bash 4.1 workaround
​46faf0c	Merge branch 't/16415/ignore_case_in_package_directory' into t/16260/vbraun/python_2_7_7
​9e1df7a	update to Python 2.7.7

[vbraun]

Maybe it can be reviewed before 2.7.8 is out...

[vbraun]

Also, last time I checked Cygwin was not a supported platform. If you take the time to check progress on the Cygwin port then that is great, but don't hold up tickets for it.

[jpflori]

Sure, this can get in without proper Cygwin support. Just don't drop patches.

[fbissey]

Looks like you rolled #16415 in that commit too.

[vbraun]

#16415 is a dependency to build on OSX.

[vbraun]

This fails with Python 2.7.7. Its testing an implementation detail, so I'll remove it:

sage -t --long src/sage/misc/weak_dict.pyx
**********************************************************************
File "src/sage/misc/weak_dict.pyx", line 84, in sage.misc.weak_dict
Failed example:
    for k in D.iterkeys():
        gc.enable()
        _ = gc.collect()
Expected:
    Traceback (most recent call last):
    ...
    RuntimeError: dictionary changed size during iteration
Got:
    <BLANKLINE>
**********************************************************************

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​e782b32

remove doctest for implementation detail

[SimonKing]

Replying to vbraun:

This fails with Python 2.7.7. Its testing an implementation detail, so I'll remove it:

sage -t --long src/sage/misc/weak_dict.pyx
**********************************************************************
File "src/sage/misc/weak_dict.pyx", line 84, in sage.misc.weak_dict
Failed example:
    for k in D.iterkeys():
        gc.enable()
        _ = gc.collect()
Expected:
    Traceback (most recent call last):
    ...
    RuntimeError: dictionary changed size during iteration
Got:
    <BLANKLINE>
**********************************************************************

Does Python now allow to change the dictionary size during iteration??? Strange.

[SimonKing]

I just notice that this tests a bug of Python's weak value dictionary. The point of this test was to show that Sage's weak value dictionary is safer. So, if Python has fixed the bug, the test has lost its purpose, and can be removed.

[vbraun]

Its still illegal to change the dictionary during iteration. Might be Issue #20437: Fixed 43 potential bugs when deleting objects references.

[SimonKing]

Replying to vbraun:

Its still illegal to change the dictionary during iteration.

Sure it is illegal. But the bug was that garbage collection used to be able to change the size of a weak dictionary during iteration. Sage has fixed it, and so has Python.

[leif]

Replying to vbraun:

#16415 is a dependency to build on OSX.

While that's not even true (it's a general fix for [almost all?] bashs but yours), merging parts of a ticket that this one is supposed to depend on doesn't make any sense to me.

So IMHO you should either remove patches to sage-spkg from the branch here, or close #16415 as a duplicate of this one, and remove the dependency. The latter would be pretty illogical IMHO.

[vbraun]

No. You merge dependencies into a branch. The Trac "Dependencies" field is for humans, and not parsed by git.

[vbraun]

Updated the branch name to contain the right Python version

[vbraun]

More explanation of the git workflow: Once the release manager merges #16415, all of the commits from that dependency ticket are no longer part of this ticket.

[leif]

Replying to vbraun:

No. You merge dependencies into a branch. The Trac "Dependencies" field is for humans, and not parsed by git.

You didn't get it, but the new/updated branch looks clean[er] (apart from having a weird commit history).

[leif]

Could we recompress the upstream tarball with bzip2 again?

(Affects the "checksums" of course.)

[vbraun]

IMHO its better to keep the upstream tarball as unmodified as possible. Its bad enough that our retarded build system can't deal with the upstream .tgz ending. But at least now the checksum is still the same as on python.org (they don't offer bz2 downloads).

[leif]

Replying to vbraun:

IMHO its better to keep the upstream tarball as unmodified as possible.

If we'd provide URLs to them...

Ideally we would have "checksums" for all kinds of tarballs (along with the URLs) whether offered by upstream / 3rd party ("almost" mirrors) or (just) us, and/or provide a checksum for the uncompressed tarball.

Its bad enough that our retarded build system can't deal with the upstream .tgz ending.

Yes, it's sad we still don't fully support MS-DOS.

But at least now the checksum is still the same as on python.org (they don't offer bz2 downloads).

Which is an upstream bug we used to fix... ;-)

Ceterum censeo Sage should support (and use) .xz (as btw. a couple of included packages do since quite some time IIRC).

[dimpase]

this upgrade appears to break pexpect (?) on OSX 10.9. Without it

sage -t src/sage/modules/vector_integer_dense.pyx

passes, with it it always hands here:

sage: vs = singular(v); vs ## line 372 ##

[jhpalmieri]

Hmm, I don't see this problem on my OS X 10.9 machine.

[dimpase]

Replying to jhpalmieri:

Hmm, I don't see this problem on my OS X 10.9 machine.

do you have the patch from #16474#comment:3 applied?

[jhpalmieri]

Replying to dimpase:

Replying to jhpalmieri:

Hmm, I don't see this problem on my OS X 10.9 machine.

do you have the patch from #16474#comment:3 applied?

I ran doctests once without it and once with it, and sage/modules/vector_integer_dense.pyx passed doctests both times.

[dimpase]

Replying to jhpalmieri:

Replying to dimpase:

Replying to jhpalmieri:

Hmm, I don't see this problem on my OS X 10.9 machine.

do you have the patch from #16474#comment:3 applied?

I ran doctests once without it and once with it, and sage/modules/vector_integer_dense.pyx passed doctests both times.

for me it only works with the #16474#comment:3 patch applied. Note that however I have this ticket's (#16260) branch merged over #16440 rather than over the current beta (6.3.beta3). Without the latter the docs won't build for me.

[vbraun]

The pexpect issue is #16474.

[dimpase]

Replying to vbraun:

The pexpect issue is #16474.

OK, sure. By the way, I checked that this ticket works on ARM, too.