Opened 7 years ago

Closed 7 years ago

#16249 closed defect (fixed)

dev.abandon() fails

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-6.2
Component: misc Keywords: beginner
Cc: Merged in:
Authors: Julian Rüth Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 807f707 (Commits) Commit: 807f7070618f351b78e918a99b756cd86bb11ffb
Dependencies: Stopgaps:

Description (last modified by saraedum)

The docstring says that the default parameter ticket_or_branch=None refers to the current branch. However, deleting the current branch is not possible. Currently, the error message is not very helpful: 

sage: dev.abandon()
ValueError: name must be a string

Now it prints: 

sage: dev.abandon()
TypeError: abandon() takes at least 2 arguments (1 given)

Change History (6)

comment:1 Changed 7 years ago by saraedum

  • Branch set to u/saraedum/ticket/16249
  • Created changed from 04/27/14 11:38:36 to 04/27/14 11:38:36
  • Modified changed from 04/27/14 11:38:36 to 04/27/14 11:38:36

comment:2 Changed 7 years ago by saraedum

  • Status changed from new to needs_review

comment:3 Changed 7 years ago by saraedum

  • Authors set to Julian Rüth
  • Branch u/saraedum/ticket/16249 deleted
  • Description modified (diff)
  • Keywords beginner added
  • Summary changed from dev.abandon(None) fails to dev.abandon() fails

comment:4 Changed 7 years ago by saraedum

  • Branch set to u/saraedum/ticket/16249
  • Modified changed from 04/27/14 11:52:54 to 04/27/14 11:52:54

comment:5 Changed 7 years ago by vbraun

  • Commit set to 807f7070618f351b78e918a99b756cd86bb11ffb
  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

New commits:

​807f707dev.abandon takes a mandatory argument

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/saraedum/ticket/16249 to 807f7070618f351b78e918a99b756cd86bb11ffb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.