Opened 5 years ago
Closed 5 years ago
#16236 closed enhancement (fixed)
Five mutually orthogonal latin squares of order 12
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.3 
Component:  combinatorics  Keywords:  design, mols 
Cc:  vdelecroix, knsam, brett  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  2d7da8a (Commits)  Commit:  2d7da8a150862462eaadd3e261ecc81abbe712c9 
Dependencies:  #16241  Stopgaps: 
Description (last modified by )
Wuuuhuuuuuuuu !! Another construction ! Given by Brendan McKay ;)
Nathann
Change History (24)
comment:1 Changed 5 years ago by
 Branch set to u/ncohen/16236
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit set to 3442d2075e4fd20a16390013c5b4a111c5803312
comment:3 Changed 5 years ago by
 Description modified (diff)
comment:4 Changed 5 years ago by
 Commit changed from 3442d2075e4fd20a16390013c5b4a111c5803312 to 491ce08b3a40cd6b00c34ffdfeb539851136cc94
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
ddda559  trac #16277: Merged with updated #16272

7570b39  trac #16277: From availability to existence and broken doctests

5e8b2af  trac #16277: removes a doctests that appears several times already

acf8988  trac #16277: Merged with updated #16231

0f3a755  trac #16235: A pair of orthogonal latin squares of order 10

316b379  trac #16235: Merged with updated #16277

e59d6cb  trac #16241: New MOLS shared by Ian Wanless

e08b0be  trac #16241: missing links and tests

fb26a1e  trac #16241: Merged with updated #16235

491ce08  trac #16236: Five mutually orthogonal latin squares of order 12

comment:7 Changed 5 years ago by
 Commit changed from 491ce08b3a40cd6b00c34ffdfeb539851136cc94 to e655b363ae30694fa5f36e6b0edbdddcfb95f0cf
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d34b012  trac #16272: Merged with updated #16227

5cab81c  trac #16286: Allow k=None in MOLS/TD/OA

4970da4  trac #16286: Merged with updated #16272

cb2e272  trac #16235: Merged with updated #16286

1a13ff8  trac #16241: New MOLS shared by Ian Wanless

2af2acf  trac #16241: missing links and tests

7e77f90  trac #16241: Broken doctests

e655b36  trac #16236: Five mutually orthogonal latin squares of order 12

comment:8 Changed 5 years ago by
 Status changed from needs_review to needs_work
comment:9 followup: ↓ 10 Changed 5 years ago by
 Dependencies changed from #16235 to #16241
 Status changed from needs_work to needs_review
Nonono actually this one is above #16241
comment:10 in reply to: ↑ 9 Changed 5 years ago by
comment:11 Changed 5 years ago by
 Status changed from needs_review to needs_work
comment:12 Changed 5 years ago by
 Commit changed from e655b363ae30694fa5f36e6b0edbdddcfb95f0cf to b51626696a83e0072ae5c9a2ef42fc505f1da37f
Branch pushed to git repo; I updated commit sha1. New commits:
a97434f  trac #16286: more doc, more tests

aeab437  trac #16235: merge the updated #16286

daa3835  trac #16235: case n=1 + doc

31a53f2  trac #16235: update the MOLS table

83b0d2c  trac #16241: Merged with updated #16235

c212bf9  trac #16241: Broken doctests

b516266  trac #16236: Merged with updated #16241

comment:13 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:14 Changed 5 years ago by
 Commit changed from b51626696a83e0072ae5c9a2ef42fc505f1da37f to f5339fabafd4d2b3ffe56b1e68bb68d75ec19902
Branch pushed to git repo; I updated commit sha1. New commits:
f5339fa  trac #16236: Broken doctests

comment:15 followup: ↓ 16 Changed 5 years ago by
Hi Nathann,
Don't you have better reference rather than "given by Brendan McKay"?
I thought that we moved TD6_12
from orthogonal_arrays
to database
... what happend?
Vincent
comment:16 in reply to: ↑ 15 ; followup: ↓ 17 Changed 5 years ago by
Yo !
Don't you have better reference rather than "given by Brendan McKay"?
Well.... I sent him an email, he gave me the matrices .... :P
I thought that we moved
TD6_12
fromorthogonal_arrays
todatabase
... what happend?
Yeah I thought I did too... Perhaps one of the conflicts, who knows ? :D
Anyway the good news is that we did not end up with a weird situation where it has not been moved WHILE some code is trying to load it from database.py. At least it works. Well, we will fix that in a later patch. I hope that Volker will release the next beta soon, because right now the Design code is a bit "foggy". It exists as a set of differences on several trac tickets, but I would like to have it in Sage and be sure that there are no conflicts anymore :D
Nathann
comment:17 in reply to: ↑ 16 ; followup: ↓ 18 Changed 5 years ago by
 Status changed from needs_review to positive_review
Replying to ncohen:
Yo !
Don't you have better reference rather than "given by Brendan McKay"?
Well.... I sent him an email, he gave me the matrices ....
:P
I thought that we moved
TD6_12
fromorthogonal_arrays
todatabase
... what happend?Yeah I thought I did too... Perhaps one of the conflicts, who knows ?
:D
Anyway the good news is that we did not end up with a weird situation where it has not been moved WHILE some code is trying to load it from database.py. At least it works. Well, we will fix that in a later patch. I hope that Volker will release the next beta soon, because right now the Design code is a bit "foggy". It exists as a set of differences on several trac tickets, but I would like to have it in Sage and be sure that there are no conflicts anymore
:D
Me too!!
comment:18 in reply to: ↑ 17 Changed 5 years ago by
Thanks for the review !
Nathann
comment:19 Changed 5 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:20 Changed 5 years ago by
Reviewer name
comment:21 Changed 5 years ago by
 Reviewers set to Vincent Delecroix
comment:22 Changed 5 years ago by
 Commit changed from f5339fabafd4d2b3ffe56b1e68bb68d75ec19902 to 2d7da8a150862462eaadd3e261ecc81abbe712c9
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
5e8b2af  trac #16277: removes a doctests that appears several times already

acf8988  trac #16277: Merged with updated #16231

485e880  trac #16277: Merged with updated #16248

411a759  trac #16286: Merged with updated #16277

11eff2c  trac #16235: Merged with 6.2

5a0e3fe  trac #16235: Merged with #16231

c0b13c4  trac #16235: Merged with updated #16286

9fb0f62  trac #16241: useless if condition in MOLS constructor

67ab2d2  trac #16241: Merged with updated #16235

2d7da8a  trac #16236: Merged with updated #16241

comment:23 Changed 5 years ago by
 Status changed from needs_review to positive_review
comment:24 Changed 5 years ago by
 Branch changed from u/ncohen/16236 to 2d7da8a150862462eaadd3e261ecc81abbe712c9
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #16236: Five mutually orthogonal latin squares of order 12