Opened 5 years ago

Closed 5 years ago

#16235 closed enhancement (fixed)

A pair of orthogonal latin squares of order 10

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorics Keywords: design, mols
Cc: vdelecroix, brett Merged in:
Authors: Nathann Cohen, Vincent Delecroix Reviewers: Vincent Delecroix, Nathann Cohen
Report Upstream: N/A Work issues: doc-pdf
Branch: 9f10ad9 (Commits) Commit: 9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15
Dependencies: #16286 Stopgaps:

Description (last modified by vdelecroix)

Heeeeeeeeeeeere it is !!

As found there : http://www.cecm.sfu.ca/organics/papers/lam/paper/html/POLS10/POLS10.html

follow up: #16241

Nathann

Change History (30)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16235
  • Status changed from new to needs_review
  • Summary changed from A pair of latin squares of order 10 to A pair of orthogonal latin squares of order 10

comment:2 Changed 5 years ago by git

  • Commit set to b65ef8bbe44b002acf4d00811b0a66161e67210a

Branch pushed to git repo; I updated commit sha1. New commits:

b65ef8btrac #16235: A pair of orthogonal latin squares of order 10

comment:3 Changed 5 years ago by ncohen

  • Dependencies set to #16231

(it does not really depend on #16231, but the two are probably in conflict as the new MOLS_10_2 function must find its place in the MOLS constructor. And it will be much easier to update this patch than #16231)

comment:4 Changed 5 years ago by ncohen

  • Cc vdelecroix brett added
  • Dependencies changed from #16231 to #16277

comment:5 Changed 5 years ago by git

  • Commit changed from b65ef8bbe44b002acf4d00811b0a66161e67210a to 0f3a755de6b9d10b12067f00691f359f93a484fa

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

2642317trac #16248: Some trivial Orthogonal Arrays
2d84806trac #16277: Merge with #16248
8b8aea8trac #16058: Organize the index of combinatorial modules
e0d2b66trac #16058: Two new categories
0293c49trac #16058: Another group
a14057bSome more groupings and separated root system types into separate list.
4b5cb2btrac #16058: Rebase on 6.2.rc0
5dbc42ftrac #16277: Merged with #16058
d4f445btrac #16277: MOLS constructions rom the Handbook of Combinatorial Designs
0f3a755trac #16235: A pair of orthogonal latin squares of order 10

comment:6 Changed 5 years ago by vdelecroix

  • Description modified (diff)

comment:7 Changed 5 years ago by git

  • Commit changed from 0f3a755de6b9d10b12067f00691f359f93a484fa to 316b3794589c63add36c6b06f08bca2bdc2ed350

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

5074eeetrac #16272: finer doctest to test the output of transversal_design
d81f265trac #16272: ultimate doctest
47798d2trac #16272: simplifying the structure of orthogonal_array
490aa7etrac #16277: Reviewer's remarks
14420b6trac #16277: Yet another construction
ddda559trac #16277: Merged with updated #16272
7570b39trac #16277: From availability to existence and broken doctests
5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
316b379trac #16235: Merged with updated #16277

comment:8 Changed 5 years ago by vdelecroix

  • Keywords design mols added

adding keywords...

comment:9 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_work

Hi Nathann,

You messed up the last merge (commit 316b379). There is a huge block

<<<<<<< HEAD
...
=======
...
>>>>>>> 0f3a755de6b9d10b12067f00691f359f93a484fa

Try again!

Vincent

comment:10 Changed 5 years ago by ncohen

On it T_T

If you feel bored while I do this (I rebased 10 branches one hour ago....) you can review #16286 ! It will become a dependency of this patch because of the MOLS table.

Nathann

comment:11 Changed 5 years ago by git

  • Commit changed from 316b3794589c63add36c6b06f08bca2bdc2ed350 to cb2e27237d73069681ec9f6d733184517618ad4f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d34b012trac #16272: Merged with updated #16227
5cab81ctrac #16286: Allow k=None in MOLS/TD/OA
4970da4trac #16286: Merged with updated #16272
cb2e272trac #16235: Merged with updated #16286

comment:12 Changed 5 years ago by ncohen

What a mess :-/

comment:13 Changed 5 years ago by ncohen

  • Dependencies changed from #16277 to #16286

comment:14 Changed 5 years ago by ncohen

  • Status changed from needs_work to needs_review

comment:15 Changed 5 years ago by vdelecroix

Hi Nathann,

You need to merge again with the last version of #16286 which has changed because of my review.

Vincent

comment:16 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_work

comment:17 Changed 5 years ago by vdelecroix

  • Branch changed from u/ncohen/16235 to public/16235
  • Commit changed from cb2e27237d73069681ec9f6d733184517618ad4f to 31a53f25033170db44455633cb03a812ae68e625
  • Status changed from needs_work to needs_review

Hi Nathann,

In the first commit, I did the rebase.

In the following ones:

  • I changed TD/MOLS to not raise an error when n=1 that you started to do in orthogonal_array (and add the appropriate doctests)... consequence: more MOLS are available!!!!!!
  • I also changed the availability into existence

Vincent


New commits:

a97434ftrac #16286: more doc, more tests
aeab437trac #16235: merge the updated #16286
daa3835trac #16235: case n=1 + doc
31a53f2trac #16235: update the MOLS table

comment:18 Changed 5 years ago by ncohen

These changes look good to me too and all tests pass, soooooo unless you have something else to add to it this can get in too :-)

Nathann

comment:19 Changed 5 years ago by vdelecroix

  • Authors changed from Nathann Cohen to Nathann Cohen, Vincent Delecroix
  • Reviewers set to Vincent Delecroix, Nathann Cohen
  • Status changed from needs_review to positive_review

Great! One more!

Vincent

comment:20 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:21 Changed 5 years ago by vbraun

Conflicts, probably with #16231 or #15310

comment:22 Changed 5 years ago by git

  • Commit changed from 31a53f25033170db44455633cb03a812ae68e625 to 5a0e3fe8b87ed052ba23cc7b5cd518af3ff8b5cd
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

11eff2ctrac #16235: Merged with 6.2
d051cf4ValueError -> EmptySetError in latin_squares
9e5e94ftrac #16231: Merged with updated #16227
5a0e3fetrac #16235: Merged with #16231

comment:23 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

Conflict with #16231 fixed.

Nathann

comment:24 Changed 5 years ago by git

  • Commit changed from 5a0e3fe8b87ed052ba23cc7b5cd518af3ff8b5cd to c0b13c440887bc38fe8c5fc86209158dc22ca655
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

f019bd3Merge branch 'u/ncohen/16248' of trac.sagemath.org:sage into 16231
490aa7etrac #16277: Reviewer's remarks
14420b6trac #16277: Yet another construction
ddda559trac #16277: Merged with updated #16272
7570b39trac #16277: From availability to existence and broken doctests
5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
485e880trac #16277: Merged with updated #16248
411a759trac #16286: Merged with updated #16277
c0b13c4trac #16235: Merged with updated #16286

comment:25 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

comment:26 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work
  • Work issues set to doc-pdf

make doc-pdf fails

comment:27 Changed 5 years ago by ncohen

..........................................

comment:28 Changed 5 years ago by git

  • Commit changed from c0b13c440887bc38fe8c5fc86209158dc22ca655 to 9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15

Branch pushed to git repo; I updated commit sha1. New commits:

e2749b3trac #16272: Merged with 6.3.beta0
6678079trac #16277: Merged with updated #16272
270c65btrac #16277: A typo
9f10ad9trac #16235: Merged with #16277

comment:29 Changed 5 years ago by ncohen

  • Status changed from needs_work to positive_review

comment:30 Changed 5 years ago by vbraun

  • Branch changed from public/16235 to 9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.