Opened 7 years ago
Closed 7 years ago
#16235 closed enhancement (fixed)
A pair of orthogonal latin squares of order 10
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.3 
Component:  combinatorics  Keywords:  design, mols 
Cc:  vdelecroix, brett  Merged in:  
Authors:  Nathann Cohen, Vincent Delecroix  Reviewers:  Vincent Delecroix, Nathann Cohen 
Report Upstream:  N/A  Work issues:  docpdf 
Branch:  9f10ad9 (Commits, GitHub, GitLab)  Commit:  9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15 
Dependencies:  #16286  Stopgaps: 
Description (last modified by )
Heeeeeeeeeeeere it is !!
As found there : http://www.cecm.sfu.ca/organics/papers/lam/paper/html/POLS10/POLS10.html
follow up: #16241
Nathann
Change History (30)
comment:1 Changed 7 years ago by
 Branch set to u/ncohen/16235
 Status changed from new to needs_review
 Summary changed from A pair of latin squares of order 10 to A pair of orthogonal latin squares of order 10
comment:2 Changed 7 years ago by
 Commit set to b65ef8bbe44b002acf4d00811b0a66161e67210a
comment:3 Changed 7 years ago by
 Dependencies set to #16231
comment:4 Changed 7 years ago by
 Cc vdelecroix brett added
 Dependencies changed from #16231 to #16277
comment:5 Changed 7 years ago by
 Commit changed from b65ef8bbe44b002acf4d00811b0a66161e67210a to 0f3a755de6b9d10b12067f00691f359f93a484fa
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
2642317  trac #16248: Some trivial Orthogonal Arrays

2d84806  trac #16277: Merge with #16248

8b8aea8  trac #16058: Organize the index of combinatorial modules

e0d2b66  trac #16058: Two new categories

0293c49  trac #16058: Another group

a14057b  Some more groupings and separated root system types into separate list.

4b5cb2b  trac #16058: Rebase on 6.2.rc0

5dbc42f  trac #16277: Merged with #16058

d4f445b  trac #16277: MOLS constructions rom the Handbook of Combinatorial Designs

0f3a755  trac #16235: A pair of orthogonal latin squares of order 10

comment:6 Changed 7 years ago by
 Description modified (diff)
comment:7 Changed 7 years ago by
 Commit changed from 0f3a755de6b9d10b12067f00691f359f93a484fa to 316b3794589c63add36c6b06f08bca2bdc2ed350
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
5074eee  trac #16272: finer doctest to test the output of transversal_design

d81f265  trac #16272: ultimate doctest

47798d2  trac #16272: simplifying the structure of orthogonal_array

490aa7e  trac #16277: Reviewer's remarks

14420b6  trac #16277: Yet another construction

ddda559  trac #16277: Merged with updated #16272

7570b39  trac #16277: From availability to existence and broken doctests

5e8b2af  trac #16277: removes a doctests that appears several times already

acf8988  trac #16277: Merged with updated #16231

316b379  trac #16235: Merged with updated #16277

comment:9 Changed 7 years ago by
 Status changed from needs_review to needs_work
Hi Nathann,
You messed up the last merge (commit 316b379). There is a huge block
<<<<<<< HEAD ... ======= ... >>>>>>> 0f3a755de6b9d10b12067f00691f359f93a484fa
Try again!
Vincent
comment:10 Changed 7 years ago by
On it T_T
If you feel bored while I do this (I rebased 10 branches one hour ago....) you can review #16286 ! It will become a dependency of this patch because of the MOLS table.
Nathann
comment:11 Changed 7 years ago by
 Commit changed from 316b3794589c63add36c6b06f08bca2bdc2ed350 to cb2e27237d73069681ec9f6d733184517618ad4f
comment:12 Changed 7 years ago by
What a mess :/
comment:13 Changed 7 years ago by
 Dependencies changed from #16277 to #16286
comment:14 Changed 7 years ago by
 Status changed from needs_work to needs_review
comment:15 Changed 7 years ago by
Hi Nathann,
You need to merge again with the last version of #16286 which has changed because of my review.
Vincent
comment:16 Changed 7 years ago by
 Status changed from needs_review to needs_work
comment:17 Changed 7 years ago by
 Branch changed from u/ncohen/16235 to public/16235
 Commit changed from cb2e27237d73069681ec9f6d733184517618ad4f to 31a53f25033170db44455633cb03a812ae68e625
 Status changed from needs_work to needs_review
Hi Nathann,
In the first commit, I did the rebase.
In the following ones:
 I changed TD/MOLS to not raise an error when n=1 that you started to do in
orthogonal_array
(and add the appropriate doctests)... consequence: more MOLS are available!!!!!!  I also changed the
availability
intoexistence
Vincent
New commits:
a97434f  trac #16286: more doc, more tests

aeab437  trac #16235: merge the updated #16286

daa3835  trac #16235: case n=1 + doc

31a53f2  trac #16235: update the MOLS table

comment:18 Changed 7 years ago by
These changes look good to me too and all tests pass, soooooo unless you have something else to add to it this can get in too :)
Nathann
comment:19 Changed 7 years ago by
 Reviewers set to Vincent Delecroix, Nathann Cohen
 Status changed from needs_review to positive_review
Great! One more!
Vincent
comment:20 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:21 Changed 7 years ago by
comment:22 Changed 7 years ago by
 Commit changed from 31a53f25033170db44455633cb03a812ae68e625 to 5a0e3fe8b87ed052ba23cc7b5cd518af3ff8b5cd
 Status changed from positive_review to needs_review
comment:23 Changed 7 years ago by
 Status changed from needs_review to positive_review
Conflict with #16231 fixed.
Nathann
comment:24 Changed 7 years ago by
 Commit changed from 5a0e3fe8b87ed052ba23cc7b5cd518af3ff8b5cd to c0b13c440887bc38fe8c5fc86209158dc22ca655
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
f019bd3  Merge branch 'u/ncohen/16248' of trac.sagemath.org:sage into 16231

490aa7e  trac #16277: Reviewer's remarks

14420b6  trac #16277: Yet another construction

ddda559  trac #16277: Merged with updated #16272

7570b39  trac #16277: From availability to existence and broken doctests

5e8b2af  trac #16277: removes a doctests that appears several times already

acf8988  trac #16277: Merged with updated #16231

485e880  trac #16277: Merged with updated #16248

411a759  trac #16286: Merged with updated #16277

c0b13c4  trac #16235: Merged with updated #16286

comment:25 Changed 7 years ago by
 Status changed from needs_review to positive_review
comment:26 Changed 7 years ago by
 Status changed from positive_review to needs_work
 Work issues set to docpdf
make docpdf
fails
comment:27 Changed 7 years ago by
..........................................
comment:28 Changed 7 years ago by
 Commit changed from c0b13c440887bc38fe8c5fc86209158dc22ca655 to 9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15
comment:29 Changed 7 years ago by
 Status changed from needs_work to positive_review
comment:30 Changed 7 years ago by
 Branch changed from public/16235 to 9f10ad9383eaa008a8ada4c1cbb90fbca84d7a15
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #16235: A pair of orthogonal latin squares of order 10