Opened 7 years ago
Closed 6 years ago
#16234 closed enhancement (fixed)
Assorted fixes and optimizations in sagecombinat (mostly partitions and tableaux)
Reported by:  darij  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  combinatorics  Keywords:  combinat, tableaux, partitions, findstat, documentation, integer_list, mutability 
Cc:  jessicapalencia, tscrim, aschilling, sagecombinat, stumpc5, VivianePons, nthiery, gchatel  Merged in:  
Authors:  Darij Grinberg  Reviewers:  Viviane Pons 
Report Upstream:  N/A  Work issues:  
Branch:  be05e3c (Commits)  Commit:  be05e3c425f97b94cb07aae5e83e5a04a12ea58e 
Dependencies:  Stopgaps: 
Description (last modified by )
 Improve documentation of promotion operators (there are three of them in Sage) on SSYTs.
 Add doc to LascouxSchützenberger action on tableaux.
 Add a few more @combinatorial_map decorators on tableaux, partitions, posets.
 Fix doc of the GreeneKleitman partition method on finite posets.
 Speed up
is_column_strict
and three further methods on tableaux. PSA: don't usecopy.deepcopy
unless you really don't know the internal structure of the objects you are copying.
 Fix a bug in the iterator of
Partitions(..., outer=a)
that causeda
to be mutated occasionally, and that requireda
to be a list (as opposed to, more reasonably, a partition or tuple):sage: a = [4,2,1,1,1,1,1] sage: for p in Partitions(8, outer=a, min_slope=1): print p ....: [3, 2, 1, 1, 1] [2, 2, 1, 1, 1, 1] [2, 1, 1, 1, 1, 1, 1] sage: a [3, 2, 1, 1, 1, 1, 1]
Change History (16)
comment:1 Changed 7 years ago by
 Status changed from new to needs_review
comment:2 Changed 7 years ago by
 Component changed from PLEASE CHANGE to combinatorics
comment:3 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:4 Changed 7 years ago by
 Cc stumpc5 VivianePons added
comment:5 Changed 6 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:6 Changed 6 years ago by
 Commit changed from 462e427a6c0f3a45d15d08f4630cc981b3609102 to c9d051fe916310d5dcfefe691193b5d44a9f9870
comment:7 Changed 6 years ago by
 Commit changed from c9d051fe916310d5dcfefe691193b5d44a9f9870 to 045ada00385e37ac746b7320388d13c2e0d9d5a2
comment:8 Changed 6 years ago by
 Cc nthiery added
 Description modified (diff)
 Keywords integer_list mutability added
 Summary changed from Some doc improvements and optimizations in sagecombinat (mostly tableaux) to Assorted fixes optimizations in sagecombinat (mostly partitions and tableaux)
comment:9 Changed 6 years ago by
 Summary changed from Assorted fixes optimizations in sagecombinat (mostly partitions and tableaux) to Assorted fixes and optimizations in sagecombinat (mostly partitions and tableaux)
comment:10 Changed 6 years ago by
 Status changed from needs_review to needs_work
Hi Darij, thank you very much for this work!
There is something wrong with the documentation of symmetric_group_action_on_values
. I must say that I didn't know this operation, so I don't know its definition. But from the code, it seems that your documentation doesn't quite correspond to what is done in the code. When you write this:
Then, let `a` be the number of opening parentheses in the word, and `b` the number of closing parentheses (notice that all opening parentheses are left of all closing parentheses). Replace the first `b` parentheses by the letters `i+1`, and replace the remaining `a` parentheses by the letters `i`.
Indeed, the action of s_1
on [[1,2]]
should give [[2,1]]
which is not a semistandard tableau... (you obtain the unmatched parenthesizes )(
). The code answers [[1,2]]
, I must say that it is quite obscure and I don't understand what they're doing. But obviously, the documentation does not explain it correctly. Do you have the paper reference where this operation is described?
Apart from that, it seems good to me.
comment:11 Changed 6 years ago by
 Cc gchatel added
comment:12 Changed 6 years ago by
 Commit changed from 045ada00385e37ac746b7320388d13c2e0d9d5a2 to be05e3c425f97b94cb07aae5e83e5a04a12ea58e
Branch pushed to git repo; I updated commit sha1. New commits:
be05e3c  fix the documentation blunder Viviane found

comment:13 Changed 6 years ago by
 Status changed from needs_work to needs_review
Thank you  this should be fixed now.
comment:14 Changed 6 years ago by
 Reviewers set to Viviane Pons
 Status changed from needs_review to positive_review
Well, this is mostly doc improvement. I read everything and it seems quite fine for me. I run the tests on every changed files and built the documentation.
comment:15 Changed 6 years ago by
Thanks for the review!
comment:16 Changed 6 years ago by
 Branch changed from public/combinat/tableauxetaldoc to be05e3c425f97b94cb07aae5e83e5a04a12ea58e
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Merge branch 'public/combinat/tableauxetaldoc' of git://trac.sagemath.org/sage into morestat
minor improvements to semistandardness testing