Opened 8 years ago

Closed 8 years ago

#16229 closed enhancement (fixed)

FiniteStateMachine._latex_ and latex_options: customize loop position

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.3
Component: combinatorics Keywords: finite_state_machine
Cc: skropf, dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 8ba3e50 (Commits, GitHub, GitLab) Commit: 8ba3e50ef768fc826beff998f2d6242e7385fe27
Dependencies: #16207 Stopgaps:

Status badges


Previously, all loops were drawn as "loop above". Introduced a new parameter loop_where of latex_options to allow "above", "below", "left" and "right", as allowed by tikz.

Change History (6)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/latex-loop to u/dkrenn/fsm/latex-loop

comment:3 Changed 8 years ago by dkrenn

  • Commit changed from 218372e190f175824cb4ef754f56b97e25e96cc9 to 8ba3e50ef768fc826beff998f2d6242e7385fe27
  • Status changed from needs_review to positive_review

Patch is fine; doctests pass; documentation ok. (corrected one PEP8-spacing during review).

New commits:

8ba3e50corrected one PEP8-spacing

comment:4 Changed 8 years ago by dkrenn

  • Reviewers set to Daniel Krenn

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 8 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/latex-loop to 8ba3e50ef768fc826beff998f2d6242e7385fe27
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.