Opened 7 years ago

Closed 5 years ago

#16221 closed enhancement (fixed)

Add (symbolic) Struve functions

Reported by: kcrisman Owned by:
Priority: minor Milestone: sage-7.2
Component: symbolics Keywords: special, holonomic
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Karl-Dieter Crisman, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: cf92ce3 (Commits) Commit: cf92ce34b1f0e865f1cbd9b635837c46aa9372e4
Dependencies: Stopgaps:

Description

Apparently Maxima has this. 

struve_h (v,z)                 Struve H function
struve_l (v,z)                 Struve L function

See #15024 and the ​symbolic wiki on Trac for more detail.

Change History (26)

comment:1 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:2 Changed 7 years ago by rws

  • Branch set to u/rws/add__symbolic__struve_functions

comment:3 Changed 7 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 03e076a4474e2e980ea76e16ff60e36e02fcbd28
  • Keywords special holonomic added
  • Status changed from new to needs_review

New commits:

​03e076a16221: implement Struve H/L functions

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 7 years ago by git

  • Commit changed from 03e076a4474e2e980ea76e16ff60e36e02fcbd28 to a6a6310813b80d68e96985e440095be2b80eae8b

Branch pushed to git repo; I updated commit sha1. New commits:

​a6a6310Merge branch 'develop' into t/16221/add__symbolic__struve_functions

comment:6 Changed 6 years ago by git

  • Commit changed from a6a6310813b80d68e96985e440095be2b80eae8b to e7ad2ee405cca158e708ae4a9dcee43c37406735

Branch pushed to git repo; I updated commit sha1. New commits:

​8b4b908Merge branch 'develop' into t/16221/add__symbolic__struve_functions
​e7ad2ee16221: simplification due to improved BuiltinFunction; better doctests

comment:7 Changed 6 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to needs_info

Comments, putting 'needs info' just so the status is clear.

  • Think we should implement A&S 12.1.15 or 12.2.10?
  • This 
    sage: struve_L(i.n(),100)
1.07916123209824e42 + 4.90584803419713e22*I
    doesn't seem to agree with ​W|A, though I don't know whether it should even be implemented.
  • ​W functions claims something that isn't in A&S but that certainly works with mpmath: 
    sage: struve_H(-2,0)
struve_H(-2, 0)
sage: struve_H(-3,0)
struve_H(-3, 0)
sage: struve_H(-3,0).n()
0.000000000000000
sage: struve_H(-2,0).n()
0.000000000000000
sage: struve_H(-7/2,0)
struve_H(-7/2, 0)
sage: struve_H(-7/2,0).n()
0.000000000000000
  • Maybe doctest at least a couple of the interfaces, at least with mpmath and Maxima? (I don't know if Maxima returns any of these when you plug in this particular DE, but if it did that would be perfect.)

Otherwise I think this is definitely ready to get in, and a useful addition!

comment:8 Changed 6 years ago by kcrisman

One more thing - just like in #15024, probably there should be a little top-matter added, just for completeness.

comment:9 Changed 6 years ago by kcrisman

(Interestingly, #18257 doesn't seem to afflict this one - maybe it didn't add as many functions as #15024.)

comment:10 Changed 6 years ago by rws

  • Status changed from needs_info to needs_work

comment:11 Changed 6 years ago by rws

  • Branch changed from u/rws/add__symbolic__struve_functions to u/rws/16221

comment:12 Changed 6 years ago by rws

  • Commit changed from e7ad2ee405cca158e708ae4a9dcee43c37406735 to 34c4d1eba8daa80f43236ebb1bc5656331e0fe7f
  • Milestone changed from sage-6.4 to sage-6.8
  • Status changed from needs_work to needs_review

That should do it. Could you please have a final glance?

New commits:

​34c4d1e16221: Struve functions

comment:13 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_work

According to the ​developer guide, .. math:: would better be .. MATH::.

There is a strange carret here (appears twice) 

+        r"""
+    ^    EXAMPLES::
+

comment:14 Changed 5 years ago by git

  • Commit changed from 34c4d1eba8daa80f43236ebb1bc5656331e0fe7f to faf5fd5976b89eaf7151b1d6f5339c78b35bec39

Branch pushed to git repo; I updated commit sha1. New commits:

​2066722Merge branch 'u/rws/16221' of trac.sagemath.org:sage into t16221
​faf5fd516221: typos

comment:15 Changed 5 years ago by rws

  • Milestone changed from sage-6.8 to sage-7.1
  • Status changed from needs_work to needs_review

comment:16 Changed 5 years ago by rws

  • Branch changed from u/rws/16221 to u/rws/16221-1

comment:17 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

doc of _print_latex_ is not formatted correctly (twice)

REFERENCE blocks are not formatted correctly either.

comment:18 Changed 5 years ago by git

  • Commit changed from faf5fd5976b89eaf7151b1d6f5339c78b35bec39 to fbb69997fc0b3f012b51e95622bba0c7638f69aa

Branch pushed to git repo; I updated commit sha1. New commits:

​2980d87Merge branch 'u/rws/16221-1' of git://trac.sagemath.org/sage into tmp05
​fbb699916221: fix doc refs and formatting

comment:19 Changed 5 years ago by rws

  • Status changed from needs_work to needs_review

comment:20 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

doc does not build: duplicate citation ASHandbook

comment:21 Changed 5 years ago by git

  • Commit changed from fbb69997fc0b3f012b51e95622bba0c7638f69aa to cf92ce34b1f0e865f1cbd9b635837c46aa9372e4

Branch pushed to git repo; I updated commit sha1. New commits:

​cf92ce316221: complete references

comment:22 Changed 5 years ago by rws

  • Status changed from needs_work to needs_review

The references in functions/ need some love in general.

comment:23 Changed 5 years ago by chapoton

  • Reviewers changed from Karl-Dieter Crisman to Karl-Dieter Crisman, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:24 Changed 5 years ago by rws

Thanks for the review!

comment:25 Changed 5 years ago by chapoton

  • Milestone changed from sage-7.1 to sage-7.2

comment:26 Changed 5 years ago by vbraun

  • Branch changed from u/rws/16221-1 to cf92ce34b1f0e865f1cbd9b635837c46aa9372e4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.