Opened 9 years ago
Closed 7 years ago
#16209 closed enhancement (fixed)
Oriented Exchange Graph
Reported by:  Alexander Garver  Owned by:  

Priority:  major  Milestone:  sage6.10 
Component:  combinatorics  Keywords:  cluster, exchange graph, SageDays64.5 
Cc:  Gregg Musiker, Emily Gunawan  Merged in:  
Authors:  Alexander Garver  Reviewers:  JeanPhilippe Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  1e97e1d (Commits, GitHub, GitLab)  Commit:  1e97e1d5604f0119ebcbf5f599ff0047c79336a9 
Dependencies:  Stopgaps: 
Description
This function takes a seed for a cluster algebra of finite type with principal coefficients and returns an orientation of its exchange graph that has the structure of a poset. It returns this orientation of the exchange graph as a poset object and as a quiver object.
Attachments (1)
Change History (23)
Changed 9 years ago by
comment:1 Changed 9 years ago by
Milestone:  sage6.2 → sage6.3 

comment:2 Changed 9 years ago by
Keywords:  cluster added 

comment:3 Changed 9 years ago by
Branch:  → u/chapoton/16209 

Commit:  → fa0d60186cf7f9bf73b8eb1ad70ab6bc5a862330 
comment:4 Changed 9 years ago by
Cc:  Gregg Musiker added 

comment:5 Changed 9 years ago by
Commit:  fa0d60186cf7f9bf73b8eb1ad70ab6bc5a862330 → 3f66020116363b17de6d5a68c6ec21554c567f69 

Branch pushed to git repo; I updated commit sha1. New commits:
3f66020  trac #16209 a little bit smoother

comment:6 Changed 9 years ago by
Thanks Frederic.
Alexander's goal was to have a working version first. Then we would streamline it together. Your suggestion to make sure we don't compute the mutation class twice is an apt one. We will be updating this in the next few weeks (busy with other projects at the moment).
Gregg
comment:7 Changed 8 years ago by
Milestone:  sage6.3 → sage6.4 

comment:8 Changed 8 years ago by
Commit:  3f66020116363b17de6d5a68c6ec21554c567f69 → 67bdd8ce642998e6c9194065e91ff45b9b14e090 

comment:9 Changed 8 years ago by
Milestone:  sage6.4 → sage6.6 

Status:  new → needs_review 
Type:  task → enhancement 
Here is a better (?) version, that does not precompute the mutation class.
comment:10 Changed 8 years ago by
Milestone:  sage6.6 → sage6.7 

comment:11 Changed 8 years ago by
Keywords:  SageDays64.5 added 

Milestone:  sage6.7 → sage6.8 
comment:12 Changed 8 years ago by
Cc:  Emily Gunawan added 

comment:13 Changed 7 years ago by
Milestone:  sage6.8 → sage6.10 

comment:15 Changed 7 years ago by
Reviewers:  → JeanPhilippe Labbé 

Status:  needs_review → needs_work 
Some tests seem to fail in sage6.9. An exception is raised with the very first example:
TypeError?: <class 'sage.combinat.cluster_algebra_quiver.cluster_seed.ClusterSeed?'> is not hashable
comment:16 Changed 7 years ago by
Commit:  67bdd8ce642998e6c9194065e91ff45b9b14e090 → 6a17c58a5e6f13b8a55efd744521bc80d5828926 

comment:17 Changed 7 years ago by
Status:  needs_work → needs_review 

ok, I think I have fixed the problem.
comment:18 Changed 7 years ago by
Commit:  6a17c58a5e6f13b8a55efd744521bc80d5828926 → 2f76a4e74dae5398094d7c41df80c58b9e6cb9ba 

Branch pushed to git repo; I updated commit sha1. New commits:
2f76a4e  trac #16209 details

comment:19 Changed 7 years ago by
Branch:  u/chapoton/16209 → u/jipilab/16209 

comment:20 Changed 7 years ago by
Branch:  u/jipilab/16209 → u/chapoton/16209 

Status:  needs_review → positive_review 
All test passed now on sage6.9.
Looks ok to me. I removed many blank spaces.
comment:21 Changed 7 years ago by
Branch:  u/chapoton/16209 → u/jipilab/16209 

Commit:  2f76a4e74dae5398094d7c41df80c58b9e6cb9ba → 1e97e1d5604f0119ebcbf5f599ff0047c79336a9 
comment:22 Changed 7 years ago by
Branch:  u/jipilab/16209 → 1e97e1d5604f0119ebcbf5f599ff0047c79336a9 

Resolution:  → fixed 
Status:  positive_review → closed 
I have made a working and documented branch from the given file. I am not convinced at all that this is the proper way to do it. Computing first the mutation class and then doing it again looks bad enough.
New commits:
trac #16209 first sketch of a working version (rough)