Opened 8 years ago

Closed 8 years ago

#16208 closed defect (fixed)

Make Sage (6.1.1/6.2.beta*) build with GCC 4.9

Reported by: Leif Leonhardy Owned by:
Priority: major Milestone: sage-6.2
Component: build Keywords: PPL ptrdiff_t Lcalc default parameters error C++
Cc: Merged in:
Authors: Leif Leonhardy Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: f6df279 (Commits, GitHub, GitLab) Commit: f6df27925673b5ccf1583215a8ee0e1987cb492a
Dependencies: Stopgaps:

Status badges

Description

GCC 4.9.0 has been released on April 22nd 2014.

Due to stricter conformance to the C++ standard, both the current stable release of Sage, 6.1.1, and the current development release, 6.2.beta8, won't build with GCC 4.9.

Luckily only two Sage packages, namely Lcalc (1.23) and PPL (1.1), are affected, and small patches which don't change any functionality are sufficient to let Sage build with the new GCC. (The same patch(es) apply to both Sage 6.1.1 and 6.2.beta8.)

Attachments (2)

lcalc-1.23_default_parameters_1.patch (1.2 KB) - added by Leif Leonhardy 8 years ago.
For reference / easier reviewing.
ptrdiff_t-ppl-1.1.patch (6.1 KB) - added by Leif Leonhardy 8 years ago.
For reference / easier reviewing.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Leif Leonhardy

Branch: u/leif/ticket/16208
Created: Apr 22, 2014, 3:23:57 PMApr 22, 2014, 3:23:57 PM
Modified: Apr 22, 2014, 3:23:57 PMApr 22, 2014, 3:23:57 PM

comment:2 Changed 8 years ago by Leif Leonhardy

Commit: 4d49914efab5a0a91f03542fb5848af7d10a1e5e
Status: newneeds_review

Haven't [yet] updated the corresponding SPKG.txt files though (listing/documenting the patches).


New commits:

b02fff5Make PPL build with GCC 4.9 (C++ name lookup issue, s/ptrdiff_t/std::ptrdiff_t).
4d49914Make Lcalc (1.23) build with GCC 4.9 (move default parameter from definition to declaration).

Changed 8 years ago by Leif Leonhardy

For reference / easier reviewing.

Changed 8 years ago by Leif Leonhardy

Attachment: ptrdiff_t-ppl-1.1.patch added

For reference / easier reviewing.

comment:3 Changed 8 years ago by Volker Braun

Looks good to me, are you going to document the patches?

comment:4 in reply to:  3 Changed 8 years ago by Leif Leonhardy

Replying to vbraun:

Looks good to me, are you going to document the patches?

Just adding the filenames to the list of patches? (There's not much more to say, other than probably referencing this ticket.)

comment:5 Changed 8 years ago by Volker Braun

Yep

comment:6 Changed 8 years ago by Volker Braun

Branch: u/leif/ticket/16208u/vbraun/ticket/16208

comment:7 Changed 8 years ago by git

Commit: 4d49914efab5a0a91f03542fb5848af7d10a1e5ef6df27925673b5ccf1583215a8ee0e1987cb492a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8bf7939Merge branch 'develop' into t/16208/ticket/16208
f6df279document patches

comment:8 Changed 8 years ago by Volker Braun

Reviewers: Volker Braun

comment:9 Changed 8 years ago by Leif Leonhardy

Ah, thanks. I of course forgot to update the SPKG.txt files.

(Although I don't like removing the old changelogs from these; they often provided valuable information, and it's a bit tedious to restore them. The commit messages in contrast -- if at all available -- frequently don't tell much, many not even a ticket number or the corresponding patch level of an spkg.)

comment:10 Changed 8 years ago by Volker Braun

they are deprecated and will be removed over time

comment:11 Changed 8 years ago by Volker Braun

Branch: u/vbraun/ticket/16208f6df27925673b5ccf1583215a8ee0e1987cb492a
Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.