Opened 7 years ago
Closed 7 years ago
#16200 closed defect (fixed)
FiniteStateMachine._latex_: typeset state labels in math mode
| Reported by: | cheuberg | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.2 |
| Component: | combinatorics | Keywords: | finite_state_machine |
| Cc: | dkrenn, skropf | Merged in: | |
| Authors: | Clemens Heuberger | Reviewers: | Daniel Krenn |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 4d389d9 (Commits, GitHub, GitLab) | Commit: | 4d389d92b022cb0b8a49b4884e8635d0fb0ae9a4 |
| Dependencies: | Stopgaps: |
Status badges
Description
Currently, state labels are not typeset in LaTeX's math mode, but transition labels are. Furthermore, the default behaviour is to pipe the label through latex(), which by definition produces output suitable for math mode. Therefore, I consider this to be a bug and change the behaviour.
This is an incompatible change; however, relying on the old behaviour will either make no difference (if the label was an integer or a string (this is protected by \text anyway)) or lead to an error when typesetting with tikz.
While doing that, I also include a space after the comma in the coordinate tuples (PEP 8 probably does not apply to TeX code included in a docstring, but nevertheless ...).
Change History (4)
comment:1 Changed 7 years ago by
- Branch set to u/cheuberg/fsm/latex-state-label
comment:2 Changed 7 years ago by
- Commit set to 4d389d92b022cb0b8a49b4884e8635d0fb0ae9a4
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Reviewers set to Daniel Krenn
- Status changed from needs_review to positive_review
reviewed changes, code is ok, doctests pass, documentation builds --> positive_review
comment:4 Changed 7 years ago by
- Branch changed from u/cheuberg/fsm/latex-state-label to 4d389d92b022cb0b8a49b4884e8635d0fb0ae9a4
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
FiniteStateMachine._latex_: typeset state labels in math mode (#16200)