Opened 6 years ago

Closed 6 years ago

#16193 closed enhancement (fixed)

Implement new methods for Kyoto path model and some fixes

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.4
Component: combinatorics Keywords:
Cc: sage-combinat, nthiery, aschilling, bsalisbury1 Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury
Report Upstream: N/A Work issues:
Branch: 2df04b9 (Commits) Commit: 2df04b9ca433c23c094cf257d7344474eb95be64
Dependencies: Stopgaps:


Implements a method for computing the truncation of the semi-infinite tensor product of crystals in the Kyoto path model. This also fixes the hashing issue mentioned in #15959.

Change History (7)

comment:1 Changed 6 years ago by tscrim

  • Branch set to public/crystals/kyoto_path_additions_fixes-16193
  • Commit set to 2df04b9ca433c23c094cf257d7344474eb95be64
  • Status changed from new to needs_review

New commits:

4e4c417Addition of truncation methods.
13be620Merge branch 'develop' into test/15959
7bdb017Fix for Kyoto path model with hash depending on the parent.
2c8ba97Merge branch 'develop' into u/tscrim/kyoto_fix-15959
bbf4917Merge branch 'develop' into u/tscrim/kyoto_fix-15959
e778bafMerge branch 'develop' into u/tscrim/kyoto_fix-15959
2df04b9Merge branch 'u/tscrim/kyoto_fix-15959' of git:// into public/crystals/additions_kyoto_path_model

comment:2 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:3 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:4 Changed 6 years ago by tscrim

  • Cc bsalisbury added

comment:5 Changed 6 years ago by tscrim

  • Cc bsalisbury1 added; bsalisbury removed

comment:6 Changed 6 years ago by bsalisbury1

  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to positive_review

The code looks good to me and seems to work as it should.

All tests passed!
Total time for all tests: 1827.4 seconds
    cpu time: 12113.3 seconds
    cumulative wall time: 13685.6 seconds

Documentation also looks good.

Elapsed time: 673.4 seconds.
Done building the documentation!

Thanks, Travis.

comment:7 Changed 6 years ago by vbraun

  • Branch changed from public/crystals/kyoto_path_additions_fixes-16193 to 2df04b9ca433c23c094cf257d7344474eb95be64
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.