Opened 8 years ago

Last modified 8 years ago

#16180 closed enhancement

Subdivide fans using PPL — at Version 2

Reported by: novoselt Owned by:
Priority: major Milestone: sage-6.3
Component: geometry Keywords: toric
Cc: vbraun, jkeitel Merged in:
Authors: Andrey Novoseltsev Reviewers:
Report Upstream: N/A Work issues:
Branch: u/novoselt/subdivide_fans_using_ppl (Commits, GitHub, GitLab) Commit: dc35d9d1dd0d10678213344f59e38481f934c338
Dependencies: Stopgaps:

Status badges

Description (last modified by novoselt)

Current Fan.subdivide() method cannot deal with fans generated by non-full-dimensional cones since it relies on PALP. In addition it is overly complicated. So let's use PPL cones for subdivision, since our toric cones already rely on them a lot. Speed-wise new method seems to work 2-3 times faster than the old one, but main advantages are brevity of code and absence of artificial limitations.

I've also cleaned up related code a bit and deprecated Cone.lattice_polytope whose primary purpose was to use PALP for subdivision.

Change History (2)

comment:1 Changed 8 years ago by novoselt

  • Branch set to u/novoselt/subdivide_fans_using_ppl

comment:2 Changed 8 years ago by novoselt

  • Authors set to Andrey Novoseltsev
  • Cc vbraun added
  • Commit set to dc35d9d1dd0d10678213344f59e38481f934c338
  • Component changed from PLEASE CHANGE to geometry
  • Description modified (diff)
  • Keywords toric added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

​a692959Use PPL for fan subdivision.
​17cb30bFix doctests due to different facet ordering in PPL and PALP.
​dc35d9dDeprecate Cone.lattice_polytope() and drop cache for Cone.polyhedron().
Note: See TracTickets for help on using tickets.