Changes between Initial Version and Version 2 of Ticket #16180
- Timestamp:
- 04/22/14 22:21:34 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #16180
-
Property
Status
changed from
new
toneeds_review
-
Property
Authors
changed from
to
Andrey Novoseltsev
- Property Cc vbraun added
-
Property
Component
changed from
PLEASE CHANGE
togeometry
-
Property
Branch
changed from
to
u/novoselt/subdivide_fans_using_ppl
- Property Keywords toric added
-
Property
Commit
changed from
to
dc35d9d1dd0d10678213344f59e38481f934c338
-
Property
Type
changed from
PLEASE CHANGE
toenhancement
-
Property
Status
changed from
-
Ticket #16180 – Description
initial v2 1 Current `Fan.subdivide()` method cannot deal with fans generated by non-full-dimensional cones since it relies on PALP. In addition it is overly complicated. So let's use PPL cones for subdivision, since our toric cones already rely on them a lot. Speed-wise new method seems to work 2-3 times faster than the old one, but main advantages are brevity of code and absence of artificial limitations. 2 3 I've also cleaned up related code a bit and deprecated `Cone.lattice_polytope` whose primary purpose was to use PALP for subdivision.