Opened 5 years ago

Closed 4 years ago

Last modified 2 years ago

#16152 closed defect (fixed)

Disable PPL use of weak symbols on Cygwin64

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords: cygwin days57 ppl weak
Cc: tscrim Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: d022720 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by embray)

It just does not work.

Upstream report: https://www.cs.unipr.it/mantis/view.php?id=1690

Change History (13)

comment:1 Changed 5 years ago by jpflori

  • Branch set to u/jpflori/ticket/16152
  • Commit set to a9bc24deb9d2dcb7046451ff7598a89bb96d42c4
  • Status changed from new to needs_review

Unfortunately there are other issues with PPL and latest MPIR from #15015. This issue is independent though.


New commits:

a9bc24dDisable use of weak symbols on Cygwin64 in PPL.

comment:2 Changed 5 years ago by vbraun

Did you open an upstream bug? IMHO this should go upstream...

comment:3 follow-up: Changed 5 years ago by jpflori

Nope... I reported on Cygwin ml but that was a long time ago. See http://www.cygwin.com/ml/cygwin/2014-01/msg00059.html

comment:4 in reply to: ↑ 3 Changed 5 years ago by jpflori

Replying to jpflori:

Nope... I reported on Cygwin ml but that was a long time ago. See http://www.cygwin.com/ml/cygwin/2014-01/msg00059.html

Which was surely the right thing to do as PPL actually tests that weak symbols are supported but in fact they are broken. I guess the real problem is just the way the import lib is generated on Cygwin64.

comment:5 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 5 years ago by jpflori

  • Cc tscrim added

comment:8 Changed 4 years ago by tscrim

  • Branch changed from u/jpflori/ticket/16152 to u/tscrim/ticket/16152-ppl
  • Commit a9bc24deb9d2dcb7046451ff7598a89bb96d42c4 deleted
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

This compiled for me on both cygwin 32 and 64. So positive review (all I did was a trivial rebase).

comment:9 Changed 4 years ago by git

  • Commit set to d02272084eb3a6d6f0cdd3f05e6aeae4541b54cc
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

a9bc24dDisable use of weak symbols on Cygwin64 in PPL.
d022720Merge branch 'u/jpflori/ticket/16152' of trac.sagemath.org:sage into u/tscrim/ticket/16152-ppl

comment:10 Changed 4 years ago by jpflori

  • Status changed from needs_review to positive_review

comment:11 Changed 4 years ago by tscrim

Forgot that git resets back to needs_review.

@jpflori you beat me by 1 second. :P

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/tscrim/ticket/16152-ppl to d02272084eb3a6d6f0cdd3f05e6aeae4541b54cc
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:13 Changed 2 years ago by embray

  • Commit d02272084eb3a6d6f0cdd3f05e6aeae4541b54cc deleted
  • Description modified (diff)
  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.

Weirdly, though I don't even remember doing so, apparently I submitted an upstream bug report about this, and the fix has now been accepted.

Note: See TracTickets for help on using tickets.