Opened 8 years ago

Closed 8 years ago

#16146 closed enhancement (fixed)

FiniteStateMachine._latex_: initial states taken into account

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.2
Component: combinatorics Keywords: finite_state_machine
Cc: skropf, dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: fe9b380 (Commits, GitHub, GitLab) Commit: fe9b3803bf0294c05014f76cc3bc8b5bd1377358
Dependencies: #16200 Stopgaps:

Status badges

Description

Previously, initial states were not taken into account.

As the output is in tikz, the parameter choosing the direction of the arrow indicating the initial state follows tikz' notations. Thus, initial_where can be set to one of "below", "above", "left", "right".

Change History (10)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by git

  • Commit changed from 50397ef8c38651a3de7e8485fa66fd0905e06f21 to a63c975c05c5855665942f4a950632e5925ad3d8

Branch pushed to git repo; I updated commit sha1. New commits:

​a63c975Merge tag '6.2.beta8' into t/16146/fsm/latex-initial-state

comment:3 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/latex-initial-state to u/dkrenn/fsm/latex-initial-state

comment:4 Changed 8 years ago by dkrenn

  • Commit changed from a63c975c05c5855665942f4a950632e5925ad3d8 to ef79bba711b33471c4cfea3b0f518b511bf1f70e
  • Reviewers set to Daniel Krenn

Very minor change.

I made another commit to make all print-statements comaptible with Python 3. Please review those and if they are fine, feel free to set this ticket to positive_review

New commits:

​002c57badded 'print' in doctests (F._latex_) to get nicer output
​ef79bbapython3: "print ..." to print(...)

comment:5 Changed 8 years ago by cheuberg

  • Status changed from needs_review to needs_work

In its current form, this will create a merge conflict with #16200. Pending resolution, I set the status back to needs_work.

comment:6 Changed 8 years ago by cheuberg

  • Branch changed from u/dkrenn/fsm/latex-initial-state to u/cheuberg/fsm/latex-initial-state
  • Commit changed from ef79bba711b33471c4cfea3b0f518b511bf1f70e to 002c57bd10785e90549b987ca5f6df2d47053432

I discard the last commit ​ef79bba python3: "print ..." to print(...) because the corresponding discussion #15989 does not seem to be closed yet.

comment:7 Changed 8 years ago by git

  • Commit changed from 002c57bd10785e90549b987ca5f6df2d47053432 to 98328da0551d82a774c098d1065fec3873bdc109

Branch pushed to git repo; I updated commit sha1. New commits:

​4d389d9FiniteStateMachine._latex_: typeset state labels in math mode (#16200)
​89c10ccMerge remote-tracking branch 'aau/fsm/latex-state-label' #16200 into fsm/latex-initial-state-new
​98328dareplace print(F._latex_()) by print latex(F) (three times)

comment:8 Changed 8 years ago by cheuberg

  • Dependencies set to #16200
  • Status changed from needs_work to needs_review

#16120 is now merged.

comment:9 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/latex-initial-state to u/dkrenn/fsm/latex-initial-state_b
  • Commit changed from 98328da0551d82a774c098d1065fec3873bdc109 to fe9b3803bf0294c05014f76cc3bc8b5bd1377358
  • Status changed from needs_review to positive_review

Marked three doctests as indirect. Now everything is fine.

New commits:

​fe9b380marked 3 doctests as indirect

comment:10 Changed 8 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/latex-initial-state_b to fe9b3803bf0294c05014f76cc3bc8b5bd1377358
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.